Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust deployment field labels, hints and validation #2863

Closed
1 task done
smbea opened this issue Mar 28, 2022 · 5 comments · Fixed by #2879
Closed
1 task done

Adjust deployment field labels, hints and validation #2863

smbea opened this issue Mar 28, 2022 · 5 comments · Fixed by #2879
Assignees

Comments

@smbea
Copy link
Contributor

smbea commented Mar 28, 2022

What should we do?

  • audience
    • find out if it's always cluster URL minus port (ask Zeebe team)
      • if so then we can omit field; if not give field description/hint
  • contact point
    • remove default text, add placeholder
    • change label to "Cluster endpoint"
    • add validation for valid url/ip address with port

Why should we do it?

This is part of a bigger effort to improve the UX of the deployment journey (see #2707)


Child of #2707

@smbea smbea self-assigned this Mar 28, 2022
@smbea smbea added the ready Ready to be worked on label Mar 28, 2022
@smbea smbea added the in progress Currently worked on label Mar 29, 2022 — with bpmn-io-tasks
@smbea smbea removed the ready Ready to be worked on label Mar 29, 2022
@smbea
Copy link
Contributor Author

smbea commented Mar 29, 2022

After reaching out to the zeebe team, I have learned that although the recommendation for audience is to be the base address of the resource being accessed (url minus the port), we cannot guarantee users will follow this in self-managed instances. Therefore -> we will maintain the audience field, but let's consider what description or placeholder could be added. (cc @christian-konrad )

@christian-konrad
Copy link
Contributor

Thanks for investigating!

Is there any documentation on OAuth in Self-Managed Camunda 8?
Or should we expect Self-Managed Users that implemented their OAuth to understand what to do in the Modeler Client? Is it the responsibility of the one installing Self-Managed to teach their users on it?

We could maybe print in the validation string “Please enter the audience your token issuer provided to you” or similar, but I am a total OAuth newbie and not sure what’s right here

@smbea
Copy link
Contributor Author

smbea commented Mar 30, 2022

@christian-konrad As far as I found no, all I found was this https://docs.camunda.io/docs/self-managed/optimize-deployment/setup/.

I'm not sure about that string because it basically says to enter the audience provided, and it seems a bit redundant. Maybe it would be more useful to have something along the lines of "Usually the base address of the cluster (without the port)"? But I'm not sure about this, since it may not always be true

@christian-konrad
Copy link
Contributor

christian-konrad commented Mar 30, 2022

it seems a bit redundant

You're right!

We also have this https://docs.camunda.io/docs/self-managed/zeebe-deployment/security/client-authorization/#environment-variables

"The address for which the token should be valid"

but it is not 100% true as the audience could be like any string - it is just a good practice to provide a URL

You may reach out to the C8 engineers and ask them to provide you a good description?

@smbea
Copy link
Contributor Author

smbea commented Mar 31, 2022

After discussing and consulting the zeebe teamm, we decided to add a description that points to it usually being the base address of the cluster (aka without the port)

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 31, 2022
smbea added a commit that referenced this issue Apr 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 1, 2022
@smbea smbea added the needs review Review pending label Apr 1, 2022 — with bpmn-io-tasks
@smbea smbea removed the in progress Currently worked on label Apr 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Apr 5, 2022
smbea added a commit that referenced this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants