Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users about hidden sequence flows #2994

Closed
remcowesterhoud opened this issue Jun 21, 2022 · 6 comments · Fixed by #3113
Closed

Warn users about hidden sequence flows #2994

remcowesterhoud opened this issue Jun 21, 2022 · 6 comments · Fixed by #3113
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux
Milestone

Comments

@remcowesterhoud
Copy link

remcowesterhoud commented Jun 21, 2022

Problem you would like to solve

When editing a model it could occur that some sequence flows are seemingly connected in one way:
image

But in reality the sequence flows behind the gateway:
image

In the first image it's very hard to see that the sequence flows doesn't target the gateway, but goes through it and targets the task. It would be great if we could improve this visually, or warn the user with linting that a flow is hidden.

Proposed solution

Move sequence flows to the foreground of the process.

Alternatives considered

Have linting detect when a sequence flow is hidden underneath some other element, giving users a warning when this is the case.

Additional context

No response

@remcowesterhoud remcowesterhoud added the enhancement New feature or request label Jun 21, 2022
@nikku
Copy link
Member

nikku commented Jun 22, 2022

Thanks for your report. We'll investigate if moving sequence flows to the front is a quick win or if we need another way to indicate such flows.

@nikku nikku added ux enhancement New feature or request spring cleaning Could be cleaned up one day and removed enhancement New feature or request labels Jun 22, 2022
@nikku
Copy link
Member

nikku commented Jun 22, 2022

If that does not work linting could be an option.

@nikku nikku added the ready Ready to be worked on label Jun 23, 2022 — with bpmn-io-tasks
@barmac
Copy link
Collaborator

barmac commented Jun 23, 2022

Thanks for your report. We'll investigate if moving sequence flows to the front is a quick win or if we need another way to indicate such flows.

So this could look like the diagram below, right?

image

I think it's worth trying out. We already draw message flows on top.

@nikku nikku removed their assignment Jul 14, 2022
@CatalinaMoisuc
Copy link
Member

Moved to backlog, we could consider this as a warning in the future.

@CatalinaMoisuc CatalinaMoisuc added the backlog Queued in backlog label Jul 19, 2022 — with bpmn-io-tasks
@CatalinaMoisuc CatalinaMoisuc removed the ready Ready to be worked on label Jul 19, 2022
@CatalinaMoisuc CatalinaMoisuc added the ready Ready to be worked on label Jul 19, 2022 — with bpmn-io-tasks
@CatalinaMoisuc CatalinaMoisuc removed the backlog Queued in backlog label Jul 19, 2022
@barmac barmac added backlog Queued in backlog and removed ready Ready to be worked on labels Jul 22, 2022
@barmac
Copy link
Collaborator

barmac commented Jul 22, 2022

Moved to backlog, we could consider this as a warning in the future.

Somehow it was still ready.

@barmac
Copy link
Collaborator

barmac commented Aug 19, 2022

There will be no hidden sequence flow once bpmn-io/bpmn-js#1717 is integrated.

@barmac barmac removed their assignment Aug 19, 2022
@barmac barmac added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Aug 19, 2022
@nikku nikku added this to the M56 milestone Aug 30, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Sep 6, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 6, 2022
* `@bpmn-o/properties-panel@0.20.0`
* `bpmn-js@9.4.0`
* `bpmn-js-properties-panel@1.6.0`
* `bpmn-moddle@9.4.0`
* `camunda-bpmn-js@0.17.0`
* `camunda-bpmn-moddle@7.0.1`
* `diagram-js@8.9.0`
* `zeebe-bpmn-moddle@0.15.0`

Closes #2994
Closes #3085
pinussilvestrus pushed a commit that referenced this issue Sep 6, 2022
* `@bpmn-o/properties-panel@0.20.0`
* `bpmn-js@9.4.0`
* `bpmn-js-properties-panel@1.6.0`
* `bpmn-moddle@9.4.0`
* `camunda-bpmn-js@0.17.0`
* `camunda-bpmn-moddle@7.0.1`
* `diagram-js@8.9.0`
* `zeebe-bpmn-moddle@0.15.0`

Closes #2994
Closes #3085
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants