Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form output values are not updated based on the changes in the input value #3273

Open
GeethaParthasarathy opened this issue Nov 3, 2022 · 5 comments
Labels
backlog Queued in backlog bug Something isn't working Forms

Comments

@GeethaParthasarathy
Copy link

Describe the bug

Create a form say with "Number" field and add a input value to it. The given input value is reflected in the output value field and the Form preview. But when we delete the value one digit by digit the last digit remains in the output field even though there is no value at all in the input value field

Steps to reproduce

  1. Create a form with number field
  2. In the input values add a value to the number say 67
  3. Now we could see the value 67 in both the preview and the output value field
  4. Delete from the last digit to the first
  5. We could see that the first digit here "6" is not deleted from the preview or the output field even though no value exists in the input field
abb59c94a521fadf7ae18d35274401ef.mp4

Expected behavior

Update the preview and the output field based on the values provided in the input field

Environment

  • OS: [Windows 10]
  • Camunda Modeler Version: [5.0.0]
  • Execution Platform: [e.g. Camunda Platform, Camunda Cloud]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Nov 3, 2022
@GeethaParthasarathy GeethaParthasarathy changed the title Form output values are not updated based on the changed in the input value Form output values are not updated based on the changes in the input value Nov 3, 2022
@marstamm
Copy link
Member

marstamm commented Nov 3, 2022

I think this is expected behavior. The input should be JSON format. Deleting the last digit makes this syntactically invalid JSON that is not accepted as input and the last valid input is used.

@smbea
Copy link
Contributor

smbea commented Nov 3, 2022

That makes sense. But I have to say it seems like a bug from the user's POV

@pinussilvestrus
Copy link
Contributor

Nice catch, indeed. A good example of why proper JSON error handling might be needed (cf. this comment).

@christian-konrad
Copy link
Contributor

@pinussilvestrus should we move/copy it to the form-js repo? I agree on the error handling

@christian-konrad
Copy link
Contributor

@pinussilvestrus I created this follow-up issue: camunda/form-playground#20

@pinussilvestrus pinussilvestrus added backlog Queued in backlog Forms labels Nov 4, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 10, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Nov 10, 2022
@smbea smbea removed their assignment Nov 10, 2022
@smbea smbea removed the in progress Currently worked on label Nov 10, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 10, 2022
@smbea smbea removed their assignment Nov 10, 2022
@smbea smbea removed the in progress Currently worked on label Nov 10, 2022
@nikku nikku added the backlog Queued in backlog label Nov 26, 2022 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working Forms
Projects
None yet
Development

No branches or pull requests

6 participants