Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate JSON errors in the input data #20

Closed
christian-konrad opened this issue Nov 3, 2022 · 2 comments
Closed

Indicate JSON errors in the input data #20

christian-konrad opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@christian-konrad
Copy link

Is your feature request related to a problem? Please describe.

When the form mock input data is invalid, the form rendering stops, but there is no indicator of that error. Users might think the error is in the form, rather than in the input json.

Describe the solution you'd like

We should indicate it in the problems panel, as well as highlight the error in the json panel.

Describe alternatives you've considered

Show an error in the form preview itself, since users may spend their attention into this window. But this may result in too much flickering of the preview window.

Additional context

Add any other context or screenshots about the feature request here.

@pinussilvestrus
Copy link
Contributor

One simple thing we can do is use the linting capabilities of the lang-json CodeMirror package.

image

We should indicate it in the problems panel

That's anyway something that would need to be fixed in the Desktop Modeler directly. What can help here is to fire an event once a parsing error happens.

formPlayground.on('formPlayground.inputDataError', function(error) {
  // do stuff, e.g. display in problems panel
});

@pinussilvestrus
Copy link
Contributor

I sketched that via bpmn-io/form-js#386

pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Nov 7, 2022
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Nov 7, 2022
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Nov 7, 2022
@pinussilvestrus pinussilvestrus added the in progress Currently worked on label Nov 8, 2022
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Nov 14, 2022
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Nov 14, 2022
philippfromme added a commit to camunda/camunda-modeler that referenced this issue Jan 3, 2023
philippfromme added a commit to camunda/camunda-modeler that referenced this issue Jan 4, 2023
philippfromme added a commit to camunda/camunda-modeler that referenced this issue Jan 4, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jan 4, 2023
lzgabel pushed a commit to lzgabel/camunda-modeler that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants