Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cmd+Shift+[ and Cmd+Shift+] as tab switch shortcuts on MacOS #3444

Closed
barmac opened this issue Feb 9, 2023 · 6 comments · Fixed by #3456
Closed

Add Cmd+Shift+[ and Cmd+Shift+] as tab switch shortcuts on MacOS #3444

barmac opened this issue Feb 9, 2023 · 6 comments · Fixed by #3456
Labels
enhancement New feature or request good first issue Good for newcomers platform:Darwin pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day ux

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 9, 2023 •
edited by nikku
Loading

Problem you would like to solve

I am frustrated that I cannot use my favorite tab switch shortcut in the Modeler. The app should follow established patterns in order to embrace smooth UX.

Proposed solution

Add Cmd+Shift+[ and Cmd+Shift+] as tab switch shortcuts on MacOS.

Alternatives considered

Do nothing and grow user's frustration.

Additional context

Browsers implement both shortcuts: Ctrl+Tab and Cmd+Shift+[.
@barmac barmac added enhancement New feature or request platform:Darwin ux labels Feb 9, 2023
@barmac
Copy link
Collaborator Author

barmac commented Feb 9, 2023

@nikku @philippfromme what are the common shortcuts on Linux and Windows?

@barmac barmac mentioned this issue Feb 9, 2023
Closed
41 tasks
@barmac barmac added the spring cleaning Could be cleaned up one day label Feb 9, 2023
@nikku
Copy link
Member

nikku commented Feb 9, 2023

what are the common shortcuts on Linux and Windows?

CTRL+TAB / CTRL+SHIFT+TAB. These work just fine.

@nikku
Copy link
Member

nikku commented Feb 9, 2023

Seems like we need MacOS specific switching here.

@nikku nikku added the good first issue Good for newcomers label Feb 9, 2023
@nikku
Copy link
Member

nikku commented Feb 9, 2023

There seems to be different shortcuts to accomplish the same thing available on MacOS.

@codygulley
Copy link
Contributor

The shortcuts of Cmd+Tab and Cmd+SHIFT+TAB are MacOS level shortcuts and thus can't be used.

We can provide different shortcuts per OS. Allowing us to maintain Control+TAB / Control+SHIFT+TAB for non-MacOS and implement something else for MacOS - maybe the suggested Cmd+SHIFT+[ / Cmd+SHIFT+] would suffice?

If we can get an agreement on the shortcuts to use then I am happy to open a PR!

@nikku
Copy link
Member

nikku commented Feb 10, 2023

@codygulley I've provided hints where the change needs to happen #3444 (comment).

As you second @barmac's comment do you want to go ahead and contribute these shortcuts (MacOS only).

@nikku nikku added the pr welcome We rely on a community contribution to improve this. label Feb 10, 2023
@codygulley codygulley mentioned this issue Feb 10, 2023
Merged
@nikku nikku added needs review Review pending in progress Currently worked on labels Feb 10, 2023 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Feb 10, 2023
barmac added a commit that referenced this issue Feb 13, 2023
@codygulley @barmac
feat: add MacOS specific switch tabs keyboard shortcuts
a328bc4 
Closes #3444

---------

Co-authored-by: Maciej Barelkowski <maciej.barelkowski@camunda.com>
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Feb 13, 2023
lzgabel pushed a commit to lzgabel/camunda-modeler that referenced this issue Apr 4, 2023
@codygulley @barmac
feat: add MacOS specific switch tabs keyboard shortcuts
593dbd2 
Closes camunda#3444

---------

Co-authored-by: Maciej Barelkowski <maciej.barelkowski@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers platform:Darwin pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 3444 Add MacOS specific switch tabs keyboard shortcuts codygulley/camunda-modeler
3 participants
@nikku @codygulley @barmac