-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcuts override the search input in template selection modal #3483
Labels
Milestone
Comments
I can not reproduce the first situation but can reproduce the second one, and other similar cases using shortcuts. Seems like the template input is not recognized as active. |
This was referenced Oct 2, 2023
nikku
changed the title
Shortcuts override the search input in template selection popup window
Shortcuts override the search input in template selection popup editor
Mar 7, 2024
nikku
changed the title
Shortcuts override the search input in template selection popup editor
Shortcuts override the search input in template selection modal
Mar 7, 2024
I can reproduce the issue in 5.21.0 but cannot reproduce the backspace-related error anymore. |
barmac
added a commit
that referenced
this issue
Mar 14, 2024
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Mar 14, 2024
nikku
pushed a commit
that referenced
this issue
Mar 14, 2024
nikku
pushed a commit
that referenced
this issue
Mar 14, 2024
nikku
pushed a commit
that referenced
this issue
Mar 19, 2024
Closed via #4195. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
If you open the template selector popup window the search input field has the focus, and if you press the button "p", everything works as expected. But if you press any button which is a shortcut, for example "n", or "a", it does not search but execute the command bound to that shortcut. The biggest problem is the backspace. Press p, and then backspace. It will remove the Task element, but won't close the Template selector popup window. If you select the template after this, it will throw an error saying :
Cannot read properties of undefined (reading 'children')
Steps to reproduce
OR
Expected behavior
When the search input field has the focus, we should disable shortcuts.
Environment
Additional context
Related to SUPPORT-21053
The text was updated successfully, but these errors were encountered: