Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts override the search input in template selection modal #3483

Closed
markfarkas-camunda opened this issue Mar 1, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working channel:support spring cleaning Could be cleaned up one day
Milestone

Comments

@markfarkas-camunda
Copy link

markfarkas-camunda commented Mar 1, 2023

Describe the bug

If you open the template selector popup window the search input field has the focus, and if you press the button "p", everything works as expected. But if you press any button which is a shortcut, for example "n", or "a", it does not search but execute the command bound to that shortcut. The biggest problem is the backspace. Press p, and then backspace. It will remove the Task element, but won't close the Template selector popup window. If you select the template after this, it will throw an error saying : Cannot read properties of undefined (reading 'children')

image

Steps to reproduce

  1. Open editor
  2. Create a new Task
  3. Click on template selection button
  4. Press "p" to start filtering the templates
  5. Press backspace to delete the letter "p"
  6. It will remove the Task

OR

  1. Open editor
  2. Create a new Task
  3. Click on template selection button
  4. Press "n" to start filtering the templates
  5. It won't filter the templates as expected but it will open the Create element context menu

Expected behavior

When the search input field has the focus, we should disable shortcuts.

Environment

  • OS: Windows 11
  • Camunda Modeler Version: 5.9.0-nightly.20230227
  • Execution Platform: Camunda Platform
  • Installed plug-ins: none

Additional context

Related to SUPPORT-21053

@markfarkas-camunda markfarkas-camunda added the bug Something isn't working label Mar 1, 2023
@smbea
Copy link
Contributor

smbea commented Mar 1, 2023

I can not reproduce the first situation but can reproduce the second one, and other similar cases using shortcuts.

Seems like the template input is not recognized as active.

@smbea smbea added the backlog Queued in backlog label Mar 1, 2023 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Oct 2, 2023
@nikku nikku added the spring cleaning Could be cleaned up one day label Oct 4, 2023
@marstamm marstamm added the backlog Queued in backlog label Nov 21, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Nov 30, 2023
@barmac barmac added the backlog Queued in backlog label Jan 8, 2024
@nikku nikku changed the title Shortcuts override the search input in template selection popup window Shortcuts override the search input in template selection popup editor Mar 7, 2024
@nikku nikku changed the title Shortcuts override the search input in template selection popup editor Shortcuts override the search input in template selection modal Mar 7, 2024
@barmac
Copy link
Collaborator

barmac commented Mar 12, 2024

I can reproduce the issue in 5.21.0 but cannot reproduce the backspace-related error anymore.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Mar 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 14, 2024
@nikku nikku added this to the M75 milestone Mar 15, 2024
@nikku
Copy link
Member

nikku commented Mar 19, 2024

Closed via #4195.

@nikku nikku closed this as completed Mar 19, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working channel:support spring cleaning Could be cleaned up one day
Projects
None yet
5 participants