Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old binding.type = property template properties aren't removed when updating template #3695

Closed
smbea opened this issue Jul 3, 2023 · 1 comment · Fixed by #3742
Closed
Assignees
Labels
Milestone

Comments

@smbea
Copy link
Contributor

smbea commented Jul 3, 2023

Describe the bug

For template properties with binding type property, if a property is present in "oldTemplate" and not present in "newTemplate" it will not be removed.

We do this for other binding types - ex: inputs - but we don't do it for these.

Steps to reproduce

  1. set templates:
v1
{
    "name": "Demo",
    "id": "demo",
    "description": "Demo",
    "version": 1,
    "appliesTo": [
      "bpmn:ServiceTask"
    ],
    "properties": [
      {
        "label": "Implementation Type",
        "type": "Hidden",
        "value": "${demoDelegate}",
        "binding": {
          "type": "property",
          "name": "camunda:delegateExpression"
        }
      }
    ]
  }
v2
 {
   "name": "Demo",
   "id": "demo",
   "description": "Demo",
   "version": 2,
   "appliesTo": [
     "bpmn:ServiceTask"
   ],
   "properties": [
     {
       "label": "Implementation Type",
       "type": "Hidden",
       "value": "external",
       "binding": {
         "type": "property",
         "name": "camunda:type"
       }
     }
   ]
 }
  1. apply v1 to a service task -> camunda:delegateExpression is in xml
  2. upgrade to v2 -> see that camunda:delegateExpression hasn't been removed

Expected behavior

Old property camunda:delegateExpression should be removed

Environment

  • Camunda Modeler Version: latest
  • Execution Platform: Camunda Platform

Additional context

Related to SUPPORT-17418

@smbea smbea added bug Something isn't working ready Ready to be worked on channel:support element templates labels Jul 3, 2023
@smbea smbea self-assigned this Jul 3, 2023
smbea added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jul 3, 2023
fake-join bot pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jul 6, 2023
@smbea smbea added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Jul 6, 2023
@smbea
Copy link
Contributor Author

smbea commented Jul 6, 2023

Fixed upstream via bpmn-io/bpmn-js-element-templates#4
Won't be included in 5.13.0 release

@nikku nikku added this to the M67 milestone Jul 6, 2023
nikku added a commit that referenced this issue Jul 20, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 20, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jul 20, 2023
marstamm pushed a commit that referenced this issue Jul 20, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants