Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem wrongly reported with missing time to live #3853

Closed
cybermotier opened this issue Sep 14, 2023 · 4 comments · Fixed by #3878
Closed

Problem wrongly reported with missing time to live #3853

cybermotier opened this issue Sep 14, 2023 · 4 comments · Fixed by #3878
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cybermotier
Copy link

Describe the bug

Editing a BPMN, a problem is reported for the BPMN with the Time to live field marked as invalid. The displayed message is: Time to live must be defined.
But a value (14) was set.

Steps to reproduce

  1. Open a BPMN
  2. Invoke Save
  3. Time to live field displayed as missing when a value is provided

Expected behavior

No problem report

Environment

Camunda Modeler system information

  • Version: 5.15.0
  • Operating System: Windows 10 amd64
  • Plugins:
  • Execution Platform: BPMN - Camunda Platform 7

Additional context

No response

@cybermotier cybermotier added the bug Something isn't working label Sep 14, 2023
@smbea
Copy link
Contributor

smbea commented Sep 14, 2023

Thanks for reporting, I can reproduce the issue. We'll look into it.

@nikku nikku added the ready Ready to be worked on label Sep 14, 2023
@nikku nikku added this to the M69 milestone Sep 22, 2023
@marstamm marstamm self-assigned this Sep 22, 2023
@marstamm
Copy link
Member

marstamm commented Sep 22, 2023

[Root Cause]

Soooo, usually we reuse the parsed moddle when we do the linting, but on save we only pass the XML. That means that we need to parse it in linting. For some reason, we do not have the camunda moddle extension in @camunda/linting, so all camunda: properties are ignored. The fix should be as simple as adding a moddle extenstion to @camunda/linting

@philippfromme
Copy link
Contributor

For some reason, we do not have the camunda moddle extension in @camunda/linting, so all camunda: properties are ignored. The fix should be as simple as adding a moddle extenstion to @camunda/linting

Ooopsie!

@marstamm
Copy link
Member

As it turns out, it is not as simple as adding another extension. As described in bpmn-io/moddle#45, moddle does not allow you to have attributes with the same name, even in different namespaces. Unfortunately, we do have overlaps for modelerTemplate attributes.

As a workaround, we can provide the diagram type (C7/C8) in the tab Config and select the needed moddle extension:

return new BpmnLinter({
modeler: 'desktop',
plugins
});

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 22, 2023
marstamm added a commit to camunda/linting that referenced this issue Sep 22, 2023
this requires a new configuration option `type = platform` to be set

related to camunda/camunda-modeler#3853
marstamm added a commit to camunda/linting that referenced this issue Sep 22, 2023
this requires a new configuration option `type = platform` to be set

related to camunda/camunda-modeler#3853
merge-me bot pushed a commit to camunda/linting that referenced this issue Sep 22, 2023
this requires a new configuration option `type = platform` to be set

related to camunda/camunda-modeler#3853
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 22, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants