Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation for Reload #3886

Closed
baalmael opened this issue Sep 25, 2023 · 1 comment · Fixed by #4072
Closed

Confirmation for Reload #3886

baalmael opened this issue Sep 25, 2023 · 1 comment · Fixed by #4072
Assignees
@smbea
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux
Milestone
M73

Comments

@baalmael
Copy link

Problem you would like to solve

Ctrl + R instantly reloads the modeler. This is dangerous, as all non saved changes to any open model (tab) are lost by doing this which can be very frustrating.

Proposed solution

If there are unsaved changes, ask for confirmation before reloading (for example: "Are you sure, you want to reload? All unsaved changes will be lost!"

Alternatives considered

  • Autosave before reloading -> not good, because saving is not what is expected by pressing Reload

Additional context

No response
@baalmael baalmael added the enhancement New feature or request label Sep 25, 2023
@nikku
Copy link
Member

nikku commented Sep 25, 2023

Thanks for the feedback. We'll investigate if there is some simple fix (ask for confirmation) as you suggested.

@nikku nikku added ready Ready to be worked on ux spring cleaning Could be cleaned up one day labels Sep 25, 2023
@CatalinaMoisuc CatalinaMoisuc added this to the M71 milestone Oct 17, 2023
@CatalinaMoisuc CatalinaMoisuc added backlog Queued in backlog and removed ready Ready to be worked on labels Oct 17, 2023
@smbea smbea modified the milestones: M71, M72 Dec 5, 2023
@nikku nikku removed this from the M72 milestone Jan 2, 2024
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to confirm reload
25322de 
Closes #3240 #3886
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to save changes before reload
fb56782 
Closes #3240 #3886
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to save changes before reload
b8d5735 
Closes #3240 #3886
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to save changes before reload
2e49432 
Closes #3240 #3886
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to save changes before reload
8df734c 
Closes #3240 #3886
@smbea smbea mentioned this issue Jan 23, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog in progress Currently worked on labels Jan 23, 2024
@smbea smbea linked a pull request Jan 23, 2024 that will close this issue
feat: dialog to save changes before reload #4072
Merged
smbea added a commit that referenced this issue Jan 23, 2024
@smbea
feat: dialog to save changes before reload
2b97e84 
Closes #3240 #3886
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 23, 2024
@nikku nikku added this to the M73 milestone Jan 23, 2024
@nikku nikku mentioned this issue Feb 5, 2024
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux
Projects
None yet
Milestone
M73
Development

Successfully merging a pull request may close this issue.

feat: dialog to save changes before reload camunda/camunda-modeler
4 participants
@nikku @baalmael @smbea @CatalinaMoisuc