Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram fails to open in application (breaks it) #4473

Closed
1 task
nikku opened this issue Aug 21, 2024 · 4 comments
Closed
1 task

Diagram fails to open in application (breaks it) #4473

nikku opened this issue Aug 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working linting
Milestone

Comments

@nikku
Copy link
Member

nikku commented Aug 21, 2024

Describe the bug

I try to open the following BPMN diagram and it breaks the application.

I only see a blank screen, and cannot to use the app. Due to the fact that "last opened diagrams" is remembered, I cannot easily recover from this, too.

Steps to reproduce

  1. open test diagram
  2. observe crash (blank screen)

Expected behavior

  • Diagram opens, validation errors (if any) show.

Environment

  • OS: Linux, Ubuntu 22
  • Camunda Modeler Version: v5.25.0
  • Execution Platform: any
  • Installed plug-ins: none

Additional context

Questions:

  • Why do our existing error boundaries not work, is there something we can improve to prevent such crash?
@nikku nikku added bug Something isn't working linting labels Aug 21, 2024
@nikku
Copy link
Member Author

nikku commented Aug 21, 2024

Root cause:

  • When sorting lint errors we assume that either id or name is present on reports, which is not the case if no-bpmn-di reports "missing DI"
  • This crashes during sorting

@nikku nikku added the ready Ready to be worked on label Aug 21, 2024
@nikku
Copy link
Member Author

nikku commented Aug 21, 2024

Moving to ready due to impact.

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Sep 11, 2024
@jarekdanielak
Copy link
Contributor

The root cause is fixed in #4518

The error is actually caught in componentDidCatch of App component, but it goes into an infinite loop. My idea would be to have the bottom panel container closed in its own error boundary so that if it crashes, it doesn't take the whole app with it. Not sure if we want to investigate it now tough.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed needs review Review pending in progress Currently worked on labels Sep 11, 2024
@nikku
Copy link
Member Author

nikku commented Sep 12, 2024

Closed via #4518

@nikku nikku closed this as completed Sep 12, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 12, 2024
@github-actions github-actions bot added this to the M81 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linting
Projects
None yet
Development

No branches or pull requests

2 participants