Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation in XML/JSON view broken #4556

Closed
philippfromme opened this issue Sep 26, 2024 · 4 comments
Closed

Indentation in XML/JSON view broken #4556

philippfromme opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@philippfromme
Copy link
Contributor

Describe the bug

The indentation in the XML and JSON view isn't working anymore. It's not displayed and I cannot indent a line using SPACE or TAB.

Camunda_Modeler_IsoCjuc5I9

Steps to reproduce

  1. Open XML or JSON view
  2. Indentation not working
  3. Cannot indent

Expected behavior

Indentation works.

Environment

  • Camunda Modeler Version: 5.28-rc.1

Additional context

No response

@philippfromme philippfromme added the bug Something isn't working label Sep 26, 2024
@barmac barmac self-assigned this Sep 26, 2024
@barmac
Copy link
Collaborator

barmac commented Sep 26, 2024

I've run git bisect, and the first commit to break it is the form-js update: 8f6662d

@barmac
Copy link
Collaborator

barmac commented Sep 26, 2024

The update installs new versions of multiple codemirror packages. I will update in the client and see if it fixes the problem.

@barmac
Copy link
Collaborator

barmac commented Sep 26, 2024

I've got a fix for this, and will create a PR in a second.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 26, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 26, 2024
@nikku
Copy link
Member

nikku commented Sep 26, 2024

Closed via #4560.

@nikku nikku closed this as completed Sep 26, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 26, 2024
@github-actions github-actions bot added this to the M81 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants