Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong 'Edit' menu on direct editing activation #708

Closed
philippfromme opened this issue Dec 5, 2017 · 2 comments
Closed

Wrong 'Edit' menu on direct editing activation #708

philippfromme opened this issue Dec 5, 2017 · 2 comments
Labels
bug Something isn't working
Milestone
M22

Comments

@philippfromme
Copy link
Contributor

Activating direct editing causes all instantiated editors to update the window menu due to the fact that they all globally listen to 'input:focus' events. The order in which they update the menu is not deterministic and so it happens that after activating direct editing in a DRD modeler the BPMN modeler is the last one to update the edit menu resulting in wrong menu entries.
@philippfromme philippfromme added the bug Something isn't working label Dec 5, 2017
@nikku
Copy link
Member

nikku commented Mar 19, 2018

Who globally listens to this? Only one editor should be active at a time, listening to anything.

@nikku nikku added the ready Ready to be worked on label Apr 23, 2018
@nikku nikku modified the milestones: M21, M22 Apr 23, 2018
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels May 9, 2018
philippfromme added a commit that referenced this issue May 9, 2018
@philippfromme
fix(dmn-editor): only update if DMN editor active
b3ccbbc 
Related to #708
@philippfromme
Copy link
Contributor Author

This is not an issue anymore thanks to d89c50c#diff-57e075e7ecec913e23ddff72c76bf914 and 2c6a7d5#diff-64ba97946e52a9cd45fbd4ccdf9de36c.

@ghost ghost removed the in progress Currently worked on label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
M22
Development

No branches or pull requests
2 participants
@nikku @philippfromme