Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels are not generated anymore for start events/gateways #824

Closed
bs11234 opened this issue Jun 5, 2018 · 4 comments
Closed

Labels are not generated anymore for start events/gateways #824

bs11234 opened this issue Jun 5, 2018 · 4 comments
Assignees
@philippfromme
Labels
BPMN bug Something isn't working Camunda 7 Flags an issue as related to Camunda Automation Platform 7 modeling
Milestone
M23

Comments

@bs11234
Copy link

bs11234 commented Jun 5, 2018

In Camunda Modeler v1.15.1 on Windows 64bit: Names of elements are not displayed anymore.

Steps to reproduce:

  1. Create a PBMN diagram
  2. Edit properties of StartEvent
  3. Type 'Start' in Name property

No label 'Start' is added to diagram. In previous versions, a bpmndi:BPMNLabel was generated for the BPMNShape and the name was displayed in the diagram.
@bs11234
Copy link
Author

bs11234 commented Jun 5, 2018

Works in v1.14.0 on Windows 64bit but not anymore in v1.15.1.

@nikku nikku added bug Something isn't working Camunda 7 Flags an issue as related to Camunda Automation Platform 7 BPMN modeling labels Jun 5, 2018
@nikku nikku added this to the M23 milestone Jun 5, 2018
@nikku
Copy link
Member

nikku commented Jun 5, 2018

Thanks for reporting.

@nikku nikku added the ready Ready to be worked on label Jun 6, 2018
@nikku
Copy link
Member

nikku commented Jun 6, 2018

This will be fixed with proper external label updating on name changes (#631).

@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Jun 6, 2018
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Jun 6, 2018
@philippfromme
fix(label-behavior): properly check for name property change
4a0f6da 
Related to camunda/camunda-modeler#824
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Jun 6, 2018
@philippfromme philippfromme added ready Ready to be worked on and removed needs review Review pending labels Jun 8, 2018
@philippfromme philippfromme assigned philippfromme and unassigned nikku Jun 8, 2018
@philippfromme
Copy link
Contributor

Closed via 4a0f6da814c45268e8a324e73a53479bd2435bbe.

@ghost ghost removed the ready Ready to be worked on label Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
BPMN bug Something isn't working Camunda 7 Flags an issue as related to Camunda Automation Platform 7 modeling
Projects
None yet
Milestone
M23
Development

No branches or pull requests
3 participants
@nikku @philippfromme @bs11234