Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set focus to new row when adding new rule #928

Closed
mschoe opened this issue Sep 27, 2018 · 4 comments · Fixed by #1997
Closed

Set focus to new row when adding new rule #928

mschoe opened this issue Sep 27, 2018 · 4 comments · Fixed by #1997
Assignees
@azeghers
Labels
channel:support DMN modeling ux
Milestone
M43

Comments

@mschoe
Copy link
Member

mschoe commented Sep 27, 2018 •
edited by pinussilvestrus
Loading

Is your feature request related to a problem? Please describe.

When I click on the bottom row of a dmn table in order to add a new rule the focus is not on the new rule

Describe the solution you'd like

  1. If I click in a specific cell of the button row the focus is in the respective cell of the new rule
  2. if I click on the plus icon the focus is on the first cell of the new rule

Describe alternatives you've considered

no alternative

Related to SUPPORT-6122
This has to be fixed in dmn-js.
@mschoe mschoe added the DMN label Sep 27, 2018
@nikku nikku added modeling ux backlog Queued in backlog labels Sep 27, 2018
@srazavi
Copy link

srazavi commented Jul 23, 2019

Related to SUPPORT-6122

@srazavi
Copy link

srazavi commented Jul 25, 2019

This popped up in support. I linked relevant support case in issue description.

@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label May 27, 2020
@prithviraj-maurya
Copy link
Contributor

Is it possible to get screenshot for this so as to reproduce it.

@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed backlog Queued in backlog labels Oct 19, 2020 — with bpmn-io-tasks
@azeghers azeghers added needs review Review pending and removed in progress Currently worked on labels Oct 20, 2020 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus mentioned this issue Oct 20, 2020
Merged
9 tasks
azeghers added a commit to bpmn-io/dmn-js that referenced this issue Oct 20, 2020
@azeghers
feat(table): focus newly created cell on adding rule
6fabe2f 
Closes camunda/camunda-modeler#928
azeghers added a commit to bpmn-io/dmn-js that referenced this issue Oct 23, 2020
@azeghers
feat(table): focus first cell of newly created row on adding rule
1142133 
Related to camunda/camunda-modeler#928
azeghers added a commit to bpmn-io/dmn-js that referenced this issue Oct 23, 2020
@azeghers
feat(table): add rule focusing behavior
c70e5b0 
-on clicking the add rule button, focus the first cell of the new row
-on clicking the last row, focus the clicked cell of the new row

Related to camunda/camunda-modeler#928
azeghers added a commit to bpmn-io/dmn-js that referenced this issue Oct 26, 2020
@azeghers
feat(add-row): add rule focusing behavior
4b3f25b 
-on clicking the add rule button, focus the first cell of the new row
-on clicking the last row, focus the clicked cell of the new row

Related to camunda/camunda-modeler#928
azeghers added a commit to bpmn-io/dmn-js that referenced this issue Oct 26, 2020
@azeghers
feat(add-row): add rule focusing behavior
6ff1714 
-on clicking the add rule button, focus the first cell of the new row
-on clicking the last row, focus the clicked cell of the new row

Related to camunda/camunda-modeler#928
pinussilvestrus pushed a commit to bpmn-io/dmn-js that referenced this issue Oct 26, 2020
@azeghers
feat(add-row): add rule focusing behavior
e17931f 
-on clicking the add rule button, focus the first cell of the new row
-on clicking the last row, focus the clicked cell of the new row

Related to camunda/camunda-modeler#928
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Oct 26, 2020
@MaxTru MaxTru added this to the M43 milestone Oct 26, 2020
@MaxTru MaxTru mentioned this issue Oct 26, 2020
Closed
29 tasks
@nikku nikku removed the spring cleaning Could be cleaned up one day label Nov 2, 2020
nikku added a commit that referenced this issue Nov 3, 2020
@nikku
deps(client): bump dmn-js and bpmn-js-properties-panel versions
d03c2a6 
Closes #1990
Closes #928
Closes #1961
@nikku nikku mentioned this issue Nov 3, 2020
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 3, 2020
@pinussilvestrus
Copy link
Contributor

Closed via d03c2a6

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 4, 2020
nikku added a commit that referenced this issue Nov 5, 2020
@nikku @merge-me
deps(client): bump dmn-js and bpmn-js-properties-panel versions
0b3a7a0 
Closes #1990
Closes #928
Closes #1961
@michaldytko michaldytko mentioned this issue May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azeghers azeghers

Labels
channel:support DMN modeling ux
Projects
None yet
Milestone
M43
Development

Successfully merging a pull request may close this issue.

deps(client): bump dmn-js and bpmn-js-properties-panel versions camunda/camunda-modeler
7 participants
@nikku @mschoe @srazavi @pinussilvestrus @prithviraj-maurya @azeghers @MaxTru