fix(project): fix incorrect zip files on MacOS #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package `electron-builder@>=20.29.0` generates incorrect zip files on MacOS. Thus, the temporary solution is to pin this dependency to `~20.28.4` until bug in `electron-builder` is fixed. Closes #1048
ghost
assigned 
|
It seems like this particular commit in |
|
Could you create an issue in electron-builder so that there is a chance that this issue gets fixed upstream, some day, maybe? Or does the issue already exist? |
|
Sure, I'll take care of this. |
|
@nikku added issue here: electron-userland/electron-builder#3534 |
nikku
approved these changes
Dec 10, 2018
delete-merged-branch
bot
deleted the
1048-fix-distro-test-archives-on-mac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins
electron-builderdependency to~20.28.4as versions after that generate incorrect zip files on MacOS. See this for reference: thejoshwolfe/yauzl#48 (comment) regarding the error produced byyauzlafter upgrade.Closes #1048