-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/App): add file drop feature #1124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned barmac
Jan 21, 2019
barmac
force-pushed
the
1085-restore-file-drop-feature
branch
3 times, most recently
from
January 22, 2019 10:22
c4a3d53
to
1907e87
Compare
Resolved conflict and rebased on HEAD. |
I'll fix this and let you know. |
barmac
force-pushed
the
1085-restore-file-drop-feature
branch
from
January 22, 2019 11:32
1907e87
to
0a59954
Compare
@philippfromme please check now |
barmac
force-pushed
the
1085-restore-file-drop-feature
branch
from
January 22, 2019 15:24
b7d7083
to
7e1b22c
Compare
barmac
force-pushed
the
1085-restore-file-drop-feature
branch
from
January 23, 2019 13:42
7e1b22c
to
422fc09
Compare
@philippfromme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1085
Closes #571
Regarding #571, dropping a text to XML editor is still possible, whereas dropping a file will trigger file opening action.