Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): restore keyboard shortcuts overlay #1127

Merged
merged 2 commits into from
Jan 22, 2019
Merged

feat(client): restore keyboard shortcuts overlay #1127

merged 2 commits into from
Jan 22, 2019

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Jan 22, 2019 •
edited
Loading

Restoring the keyboard shortcuts overlay

jan-22-2019 11-18-10

Closes #1039
Closes #1040

@ghost ghost assigned pinussilvestrus Jan 22, 2019
@ghost ghost added the needs review Review pending label Jan 22, 2019
@ghost ghost assigned barmac Jan 22, 2019
barmac
barmac approved these changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@barmac
Copy link
Collaborator

barmac commented Jan 22, 2019

Applied small simplification before approval, see: 2fa9480

@merge-me merge-me bot merged commit 1a0968e into master Jan 22, 2019
@ghost ghost removed the needs review Review pending label Jan 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1040-restore-shortcuts-overlay branch January 22, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@pinussilvestrus pinussilvestrus

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinussilvestrus @barmac