Integrate cloud templates #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
pinussilvestrus
requested review from
MaxTru,
a team and
barmac
and removed request for
a team
pinussilvestrus
force-pushed
the
2731-rollout-cloud-templates
branch
from
c6d90b2
to
edad233
Compare
added 7 commits
February 28, 2022 10:01
Moved to `bpmn-shared' folder.
pinussilvestrus
force-pushed
the
2731-rollout-cloud-templates
branch
from
edad233
to
2cf327f
Compare
|
I will look into this today afternoon. |
This was referenced Feb 28, 2022
barmac
reviewed
Feb 28, 2022
barmac
reviewed
Feb 28, 2022
barmac
reviewed
Feb 28, 2022
barmac
reviewed
Feb 28, 2022
|
I left a couple of comments and tested this locally. Looks good overall. |
* update on `elementTemplates.changed` is handled via `bpmn-js-properties-panel`
barmac
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2731
Closes #2496
Closes #2749
Closes #2673
camunda-bpmn-js@0.13.0-alpha.3cloud-element-templatesfeature tocloud-bpmntabsElementTemplatesValidatorprovided viacamunda-bpmn-js$schemaattribute => needs to be provided + reference@camunda/zeebe-element-templates-json-schema(that needs to be documented, cf. Update element template docs #2723)cloud-bpmntabsSome samples to try out, note that
$schemaneeds to be set for cloud templates (cf. above).