Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Form Linting #2891

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Fix Form Linting #2891

merged 5 commits into from
Apr 6, 2022

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Apr 5, 2022 •
edited
Loading

  • add latest Camunda versions to form linter
  • sort lint errors alphabetically

NciZFR29k1

Closes #2880
Closes #2885

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 5, 2022
@philippfromme philippfromme changed the title Linting 2 Fix Form Linting Apr 6, 2022
@philippfromme philippfromme marked this pull request as ready for review April 6, 2022 09:31
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 6, 2022
@philippfromme
Copy link
Contributor Author

Artifacts

MaxTru
MaxTru requested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!
works

Just one minor thing

client/src/app/tabs/panel/tabs/LintingTab.js Outdated Show resolved Hide resolved
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 6, 2022
@philippfromme philippfromme merged commit ba6c7fd into develop Apr 6, 2022
@philippfromme philippfromme deleted the linting-2 branch April 6, 2022 12:01
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Apr 6, 2022
@MaxTru MaxTru mentioned this pull request Apr 6, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@philippfromme @MaxTru