Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct feel error css #3124

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix: correct feel error css #3124

merged 1 commit into from
Sep 8, 2022

Conversation

marstamm
Copy link
Member

@marstamm marstamm commented Sep 8, 2022

Uses the correct CSS and sets the complete border to red

Old:
image

New:
image

- bpmn-js-properties-panel@1.6.1
- camunda-bpmn-js@0.17.2
@marstamm marstamm requested a review from a team September 8, 2022 12:43
@marstamm marstamm self-assigned this Sep 8, 2022
@marstamm marstamm requested review from philippfromme and pinussilvestrus and removed request for a team September 8, 2022 12:43
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 8, 2022
@pinussilvestrus
Copy link
Contributor

That should go to master, right?

@marstamm marstamm changed the base branch from develop to master September 8, 2022 12:45
@marstamm
Copy link
Member Author

marstamm commented Sep 8, 2022

Yes, I changed it 👍

Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 🏁

@pinussilvestrus pinussilvestrus merged commit f3a473f into master Sep 8, 2022
@pinussilvestrus pinussilvestrus deleted the fix-feel-error-style branch September 8, 2022 12:59
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 8, 2022
@marstamm
Copy link
Member Author

marstamm commented Sep 8, 2022

I was wondering why it said "merge failed" until I refreshed the page and you already did it 😄

@pinussilvestrus
Copy link
Contributor

You were quicker than GitHub's page updater 😄

@pinussilvestrus pinussilvestrus mentioned this pull request Sep 9, 2022
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants