Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update @camunda/linting to v0.9.1 #3279

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

philippfromme
Copy link
Contributor

Closes #3148

Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this:
image

It should say Zeebe 1.0.0.

@philippfromme
Copy link
Contributor Author

Something is wrong with this:

I'll look into this.

@marstamm
Copy link
Member

marstamm commented Nov 8, 2022

@philippfromme

It looks like the util needs to cast the PlatformVersion to Minor before doing the label translation
https://github.com/camunda/linting/blob/main/lib/utils/error-messages.js#L28-L42

@philippfromme
Copy link
Contributor Author

@philippfromme

It looks like the util needs to cast the PlatformVersion to Minor before doing the label translation https://github.com/camunda/linting/blob/main/lib/utils/error-messages.js#L28-L42

Yes, we do this in other places but I forgot it here. 🙈

@marstamm
Copy link
Member

marstamm commented Nov 8, 2022

And I missed it in the review 🙉

@philippfromme
Copy link
Contributor Author

Updated @camunda/linting to v0.9.1 which fixes the issue with the execution platform label.

image

@philippfromme philippfromme changed the title deps: update @camunda/linting to v0.9.0 deps: update @camunda/linting to v0.9.1 Nov 8, 2022
@philippfromme philippfromme merged commit 7401280 into develop Nov 9, 2022
@philippfromme philippfromme deleted the linting-update branch November 9, 2022 11:30
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show version that enables the feature if not supported in currently selected version
3 participants