Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to bpmn-js-properties-panel@1.11.2 #3306

Merged
merged 3 commits into from
Nov 18, 2022
Merged

deps: update to bpmn-js-properties-panel@1.11.2 #3306

merged 3 commits into from
Nov 18, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 18, 2022 •
edited
Loading

We had to override the existing properties provider to not introduce breaking changes.

Closes #3304
Closes #3303

Artifacts for Testing

https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/implementation-detail-error/camunda-modeler-implementation-detail-error-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/implementation-detail-error/camunda-modeler-implementation-detail-error-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/implementation-detail-error/camunda-modeler-implementation-detail-error-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/implementation-detail-error/camunda-modeler-implementation-detail-error-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/implementation-detail-error/camunda-modeler-implementation-detail-error-win-x64.zip

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 18, 2022
@nikku nikku marked this pull request as ready for review November 18, 2022 15:19
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 18, 2022
@nikku nikku requested review from marstamm, a team and smbea and removed request for a team November 18, 2022 15:19
@nikku nikku mentioned this pull request Nov 18, 2022
Closed
17 tasks
@nikku nikku force-pushed the implementation-detail-error branch from a22647a to cf43dff Compare November 18, 2022 15:46
marstamm
marstamm approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks for providing the artifacts, makes trying it out much easier

@nikku nikku merged commit eeab284 into master Nov 18, 2022
@nikku nikku deleted the implementation-detail-error branch November 18, 2022 16:54
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from camunda/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @marstamm