Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass certificate to zeebe even if appears invalid #3415

Merged
merged 1 commit into from
Jan 30, 2023
Merged

feat: pass certificate to zeebe even if appears invalid #3415

merged 1 commit into from
Jan 30, 2023

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Jan 30, 2023

So that we can still detect problems and give guidance but not enforce too rigid validation.

@barmac barmac requested a review from nikku January 30, 2023 09:29
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 30, 2023
@barmac barmac force-pushed the pass-cert-even-if-appears-invalid branch from a063835 to f9af8c7 Compare January 30, 2023 09:47
@barmac barmac requested a review from nikku January 30, 2023 09:47
nikku
nikku approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I integration tested and it works. 🎉

@nikku nikku added this to the M61 milestone Jan 30, 2023
@nikku nikku merged commit 2191906 into develop Jan 30, 2023
@nikku nikku deleted the pass-cert-even-if-appears-invalid branch January 30, 2023 10:26
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 30, 2023
@nikku nikku mentioned this pull request Feb 8, 2023
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
M61
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @nikku