feat: add Linter element-templates linter plugin #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
marstamm
force-pushed
the
3357-integrate-linter
branch
4 times, most recently
from
3da43f0
to
0097386
Compare
marstamm
requested review from
a team,
philippfromme and
smbea
and removed request for
a team
bpmn-io-tasks
bot
added
needs review
1 task
marstamm
force-pushed
the
3357-integrate-linter
branch
from
0097386
to
fbb556a
Compare
|
Pinging @philippfromme as you already did the review on bpmn-io/bpmn-js-element-templates#3 |
marstamm
force-pushed
the
3357-integrate-linter
branch
2 times, most recently
from
fb280b4
to
7a71714
Compare
client/src/app/TabsProvider.js
Outdated
| @@ -194,10 +197,16 @@ export default class TabsProvider { | |||
| action: 'create-cloud-bpmn-diagram' | |||
| } ]; | |||
| }, | |||
| getLinter(plugins) { | |||
| async getLinter(plugins = [], tab, app) { | |||
There was a problem hiding this comment.
I'm not too fond of the idea of passing the entire app here. Might as well get the tab from the app then. Usually we only pass the options (e.g. getInitialContents(options)) or the file (e.g. canOpen(file)). I know we need to get hold of the templates, though. 🤔
There was a problem hiding this comment.
We could limit it to getConfig so we don't pass the whole app
marstamm
force-pushed
the
3357-integrate-linter
branch
from
ae885ef
to
cc1b012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3357