chore: update dependency electron to v25 #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
nikku
force-pushed
the
renovate/electron-25.x
branch
from
98caff0
to
25e7a25
Compare
nikku
changed the title
nikku
reviewed
Jul 20, 2023
There was a problem hiding this comment.
This works for me on Linux, testing most platform related concerns (cf. integration tests).
@camunda/modeling-dev can I get two smoke tests from your for Windows and MacOS?
renovate
bot
changed the title
|
I'll check it out on Windows. |
|
Builds and runs on Windows. ✅ |
|
Builds, runs on MacOS and basic file opening and saving also work |
|
Thanks! :) |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
nikku
force-pushed
the
renovate/electron-25.x
branch
from
36f7d66
to
21bac84
Compare
nikku
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^22.0.0->^25.0.0Release Notes
electron/electron (electron)
v25.3.1: electron v25.3.1Compare Source
Release Notes for v25.3.1
Fixes
BrowserWindow.moveAbove()andBrowserWindow.moveTop()did not work for child windows on macOS. #39071 (Also in 24, 26)openFilewas not passed as a dialog property. #39096 (Also in 24, 26)webContents.print({ silent: true })not working correctly. #39095 (Also in 26)Other Changes
v25.3.0: electron v25.3.0Compare Source
Release Notes for v25.3.0
Features
session.downloadURL(). #38870 (Also in 26)Fixes
protocol.handle()never called its callback with the'file'scheme. #39064Showbutton visible. #39014 (Also in 24, 26)Unknown
BrowserViewscan behave inconsistently across platforms. #39005 (Also in 26)v25.2.0: electron v25.2.0Compare Source
Release Notes for v25.2.0
Features
node:prefixed requires are now supported in sandboxed renderer preloads forevents,timersandurl. #38729 (Also in 24, 26)Fixes
webContents.printToPDFpreferCSSPageSizetype error. #38791 (Also in 24, 26)nativeThemesource during mara context menu close. #38839 (Also in 26)webContents.print()stopped triggering its callback when the user cancelled the print dialog. #38814 (Also in 26)Other Changes
v25.1.1: electron v25.1.1Compare Source
Release Notes for v25.1.1
Fixes
webContents.printparameter validation by adding missing options required to set printer printable area. #38720 (Also in 26)webContents.print(null)could incorrectly trigger an error. #38642 (Also in 24, 26)v25.1.0: electron v25.1.0Compare Source
Release Notes for v25.1.0
Features
Fixes
<datalist>popups are positions incorrectly inBrowserViews. #38609 (Also in 23, 24, 26)Other Changes
contentTracing.stopRecording()fails because no trace was in progress. #38519 (Also in 23, 24)v25.0.1: electron v25.0.1Compare Source
Release Notes for v25.0.1
Fixes
Other Changes
v25.0.0: electron v25.0.0Compare Source
Release Notes for v25.0.0
Stack Upgrades
114.0.5735.4518.15.011.4Features
cursor-changedevent. #38363 (Also in 24)webContentsmethods to center text selection, scroll to the page bottom and top, as well as adjust selected text. #38362context-menuevent from extensions. #38356httpOnlyto the cookie filter. #37255 (Also in 24)logUsagetoshell.openExternal()options, which allows passing theSEE_MASK_FLAG_LOG_USAGEflag toShellExecuteExon Windows. #37139 (Also in 24)net.fetch(). #36733protocol.handle, replacing and deprecatingprotocol.{register,intercept}{String,Buffer,Stream,Http,File}Protocol. #36674typestowebRequestfilter. #30914 (Also in 24)will-frame-navigateevent towebContentsand the<webview>tag, which fires whenever any frame within the frame hierarchy attempts to navigate. #34418app. #38018webContents.print(). #37159 (Also in 22, 23, 24)enableLocalEchoflag to the session handlerses.setDisplayMediaRequestHandler()callback for allowing remote audio input to be echoed in the local output stream whenaudiois aWebFrameMain. #37315 (Also in 23, 24)powerMonitor. #38028 (Also in 24)net.fetchto support requests tofile:URLs and custom protocols registered withprotocol.register*Protocol. #36606audio-state-changedevent onwebContents. #37366Fixes
AXManualAccessibilityattribute works as expected in all relevant protocol methods. #38223 (Also in 23, 24)webContents.printwith invalid settings. #38230FrameViews always appeared inactive regardless of focus status. #38473BrowserWindow.isMaximized()could incorrectly return true for minimized or fullscreened windows on macOS. #38307 (Also in 23, 24)BrowserWindow.isVisible()would incorrectly returntruefor minimized windows on Windows. #38314 (Also in 23, 24)MediaStreamTrack.getCaptureHandle()always returnednull. #38433 (Also in 24)getNormalBounds()returns incorrect bounds for transparent maximized windows on Windows. #38348 (Also in 23, 24)BrowserWindow.idthrew an error after the window was destroyed. #38311 (Also in 23, 24)win.minimize()directly after callingwin.maximize(), and then callingwin.isMaximized()incorrectly returnstrue. #38345 (Also in 23, 24)AXManualAccessibilityto enable a11y features in Electron. #38146 (Also in 23, 24)FrameViews always appeared inactive regardless of focus status. #38473MediaStreamTrack.getCaptureHandle()always returnednull. #38433 (Also in 24)abouton Linux as well. #37873 (Also in 23, 24)BrowserWindowfullscreening is disabled. #37348 (Also in 23, 24)AXManualAccessibilityattribute works as expected in all relevant protocol methods. #38223 (Also in 23, 24)destroyedevent not emitted oncloseforBrowserView.webContents. #37420 (Also in 23, 24)BrowserViews are present and a user attempts to preventbeforeunloadin the renderer process. #37205 (Also in 22, 23, 24)webContents.printwith invalid settings. #38230Fn+Fsystem shortcut would fail or create strange window side effects. #37803 (Also in 23, 24)BroadcastChanneldid not work correctly whencontextIsolation: false. #37421 (Also in 24)minWidth/minHeightandmaxWidth/maxHeightwould not be enforced if the user set anaspectRatioon macOS. #37306 (Also in 22, 23, 24)port.postMessageinMessagePortMainwith some invalid parameters could cause a crash. #37585 (Also in 22, 23, 24)hasReplyandactionsto a main process Notification on macOS resulted in the first action being obscured and unavailable. #37381 (Also in 22, 23, 24)did-fail-load. #37824AXManualAccessibilityto enable a11y features in Electron. #38146 (Also in 23, 24)shell.openExternal()options. #38071 (Also in 22, 23, 24)node-gypversion innode.herror. #37926 (Also in 22, 23, 24)session.cookies.setfailure. #37586 (Also in 22, 23, 24)app.showAboutPanel()no longer blocks the main thread on Windows or Linux, thus matching macOS. #37440 (Also in 24)Other Changes
1404797. #38333chrome://accessibility. #382111437346.1439691.1425115.1431761.chrome://accessibility. #38211contents.takeHeapSnapshot. #37434 (Also in 22, 23, 24)nativeImage.createThumbnailFromPath()now takessizeinstead ofmaxSize. #37362 (Also in 24)Documentation
v24.6.4: electron v24.6.4Compare Source
Release Notes for v24.6.4
Fixes
BrowserWindow.moveAbove()andBrowserWindow.moveTop()did not work for child windows on macOS. #39072 (Also in 25, 26)navigator.connectionreturned incorrect data. #39100 (Also in 25)openFilewas not passed as a dialog property. #39097 (Also in 25, 26)v24.6.3: electron v24.6.3Compare Source
Release Notes for v24.6.3
Fixes
Showbutton visible. #39012 (Also in 25, 26)v24.6.2: electron v24.6.2Compare Source
Release Notes for v24.6.2
Other Changes
1454860. #38947v24.6.1: electron v24.6.1Compare Source
Release Notes for v24.6.1
Fixes
preloadscript may not run in some child windows opened bywindow.open. #38932 (Also in 23, 25, 26)BrowserWindow.removeBrowserView()with a destroyedwebContents. #38884 (Also in 25, 26)v24.6.0: electron v24.6.0Compare Source
Release Notes for v24.6.0
Features
node:prefixed requires are now supported in sandboxed renderer preloads forevents,timersandurl. #38727 (Also in 25, 26)Fixes
webContents.printToPDFpreferCSSPageSizetype error. #38792 (Also in 25, 26)Other Changes
1450536. #38787v24.5.1: electron v24.5.1Compare Source
Release Notes for v24.5.1
Fixes
webContents.print(null)could incorrectly trigger an error. #38640 (Also in 25, 26)Other Changes
1431532. #387111447430.1444195.v24.5.0: electron v24.5.0Compare Source
Release Notes for v24.5.0
Features
Fixes
<datalist>popups are positions incorrectly inBrowserViews. #38608 (Also in 23, 25, 26)v24.4.1: electron v24.4.1Compare Source
Release Notes for v24.4.1
Fixes
MediaStreamTrack.getCaptureHandle()always returnednull. #38434 (Also in 25)Other Changes
contentTracing.stopRecording()fails because no trace was in progress. #38520v24.4.0: electron v24.4.0Compare Source
Release Notes for v24.4.0
Features
cursor-changedevent. #38364 (Also in 25)Fixes
getNormalBounds()returns incorrect bounds for transparent maximized windows on Windows. #38349 (Also in 23, 25)Other Changes
v24.3.1: electron v24.3.1Compare Source
Release Notes for v24.3.1
Fixes
BrowserWindow.isMaximized()could incorrectly return true for minimized or fullscreened windows on macOS. #38308 (Also in 23, 25)BrowserWindow.isVisible()would incorrectly returntruefor minimized windows on Windows. #38313 (Also in 23, 25)BrowserWindow.idthrew an error after the window was destroyed. #38310 (Also in 23, 25)win.minimize()directly after callingwin.maximize(), and then callingwin.isMaximized()incorrectly returnstrue. #38343 (Also in 23, 25)Other Changes
1433328. #38271v24.3.0: electron v24.3.0Compare Source
Release Notes for v24.3.0
Features
Fixes
AXManualAccessibilityattribute works as expected in all relevant protocol methods. #38224 (Also in 23, 25)v24.2.0: electron v24.2.0Compare Source
Release Notes for v24.2.0
Features
powerMonitor. #38027 (Also in 25)Fixes
AXManualAccessibilityto enable a11y features in Electron. #38147 (Also in 23)v24.1.3: electron v24.1.3Compare Source
Release Notes for v24.1.3
Fixes
shell.openExternal()options. #38072 (Also in 22, 23, 25)Other Changes
v24.1.2: electron v24.1.2Compare Source
Release Notes for v24.1.2
Fixes
Other Changes
v24.1.1: electron v24.1.1Compare Source
Release Notes for v24.1.1
Fixes
node-gypversion innode.herror. #37927 (Also in 22, 23, 25)v24.1.0: electron v24.1.0Compare Source
Release Notes for v24.1.0
Features
session.resolveHostfor resolving hostnames with Chromium's DNS resolver. #37847Fixes
abouton Linux as well. #37872 (Also in 23, 25)Fn+Fsystem shortcut would fail or create strange window side effects. #37823 (Also in 23)Other Changes
v24.0.0: electron v24.0.0Compare Source
Release Notes for v24.0.0
Stack Upgrades
Breaking Changes
nativeImage.createThumbnailFromPath()now takessizeinstead ofmaxSize. #37796Features
httpOnlyto the cookie filter. #37365logUsagetoshell.openExternal()options, which allows passing theSEE_MASK_FLAG_LOG_USAGEflag toShellExecuteExon Windows. #37291typestowebRequestfilter. #37427webContents.print(). #37265 (Also in 22, 23)enableLocalEchoflag to the session handlerses.setDisplayMediaRequestHandler()callback for allowing remote audio input to be echoed in the local output stream whenaudiois aWebFrameMain. #37528 (Also in 23)Fixes
BrowserWindowfullscreening is disabled. #37368 (Also in 23)destroyedevent not emitted oncloseforBrowserView.webContents. #37450 (Also in 23)BrowserViews are present and a user attempts to preventbeforeunloadin the renderer process. #37268 (Also in 22, 23)BroadcastChanneldid not work correctly whencontextIsolation: false. #37443 (Also in 23)minWidth/minHeightandmaxWidth/maxHeightwould not be enforced if the user set anaspectRatioon macOS. #37456 (Also in 22, 23)port.postMessageinMessagePortMainwith some invalid parameters could cause a crash. #37726 (Also in 22, 23)hasReplyandactionsto a main process Notification on macOS resulted in the first action being obscured and unavailable. #37449 (Also in 22, 23)