Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use POSIX Paths Consistently With fast-glob #3863

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Use POSIX Paths Consistently With fast-glob #3863

merged 4 commits into from
Sep 20, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Sep 20, 2023 •
edited
Loading

Added 5578416 to verify the fix. globFiles is now being used by element templates and plugins feature.

Closes #3862

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 20, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
@philippfromme philippfromme changed the base branch from develop to master September 20, 2023 09:01
nikku
nikku reviewed Sep 20, 2023
View reviewed changes
app/lib/util/files.js Outdated Show resolved Hide resolved
nikku
nikku reviewed Sep 20, 2023
View reviewed changes
app/lib/util/files.js

const {
searchPaths,
pattern
...otherOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose otherOptions for the options that will be passed to globSync. searchPaths should not be included in those options.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this declaration, my bad 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it simpler to re-use globFiles recursively: d65a838.

Let me know if this works for you, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍🏻

nikku
nikku reviewed Sep 20, 2023
View reviewed changes
app/lib/util/files.js Outdated Show resolved Hide resolved
@nikku
Copy link
Member

nikku commented Sep 20, 2023

Verified this works locally (Linux), too.

@philippfromme
Copy link
Contributor Author

I'm double-checking that element templates are working.

@philippfromme
Copy link
Contributor Author

Element templates are working as well.

@philippfromme
Copy link
Contributor Author

@nikku I think this is good to go. @barmac Feel free to check this out.

@nikku nikku merged commit 74b4792 into master Sep 20, 2023
10 checks passed
@nikku nikku deleted the fix-glob-windows branch September 20, 2023 11:48
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 20, 2023
@philippfromme philippfromme mentioned this pull request Sep 20, 2023
Closed
barmac
barmac reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on Mac. Solid as 🪨

@philippfromme philippfromme mentioned this pull request Sep 20, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku left review comments

@barmac barmac barmac left review comments

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element Templates and Plugins not found by Camunda Modeler 5.15 on Windows
3 participants
@philippfromme @nikku @barmac