feat(version-info): update to v5.20.0 #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
crobbins215,
lmbateman,
a team,
philippfromme and
marstamm
and removed request for
a team
barmac
reviewed
Feb 5, 2024
barmac
reviewed
Feb 5, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
lmbateman
reviewed
Feb 5, 2024
There was a problem hiding this comment.
This looks good to me! A couple of very minor suggestions:
- "a HTML component" --> "an HTML component"
- "Remember recently opened files" -- the other headers are noun phrases, and this is a verb phrase. Maybe "List of recently-opened files" or just "Recently-opened files"? (Also, I think "recently-opened" should have a hyphen because it's a modifier.)
- "re-open" --> "reopen"
- For "Improved properties and FEEL editing", is there somewhere I can go for a full list of improvements? Not strictly necessary, but people might be curious. I think the others are fairly self-explanatory.
|
Thanks for your feedback. I think I addressed most of it with 697e523. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing the following what's new communication: