Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite to use act to increase stability #4163

Closed
wants to merge 1 commit into from
Closed

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 28, 2024

Aims to address the constant test failures on Windows (#4154 (comment)).

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 28, 2024
@nikku
Copy link
Member Author

nikku commented Feb 28, 2024

Does not fix the tests on Windows, I stop investigating now.

To be checked by @philippfromme if he can reproduce this. Otherwise let's simply skip the test conditionally, or rewrite the suite entirely (not easy at this stage).

@nikku nikku added backlog Queued in backlog and removed needs review Review pending labels Feb 28, 2024
@nikku nikku marked this pull request as draft February 28, 2024 08:00
@nikku nikku removed their assignment Feb 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Feb 28, 2024
@nikku nikku added ready Ready to be worked on and removed in progress Currently worked on labels Feb 28, 2024
@nikku nikku added the backlog Queued in backlog label Mar 14, 2024 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Mar 14, 2024
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 11, 2024
@philippfromme
Copy link
Contributor

Already fixed via 6245e57.

@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants