feat(cloud-bpmn): add variable outline tab #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
jarekdanielak and
barmac
and removed request for
a team
|
@jarekdanielak Please have a look into this (review). |
| <VariableTab | ||
| id={ this.props.id } | ||
| layout={ layout } | ||
| injector={ this.getModeler().get('injector') } /> |
There was a problem hiding this comment.
Perhaps extract injector to a variable like imported is in this scope.
jarekdanielak
approved these changes
Aug 22, 2024
marstamm
force-pushed
the
integrate-variable-outline
branch
from
e58a314
to
da0ba48
Compare
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds the Variable tab to the desktop modeler.
related to #4267
Integration was also tested in the variable-outline PR: bpmn-io/variable-outline#1
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}