Fix variable outline styles #4497
Conversation
bpmn-io-tasks
bot
added
needs review
philippfromme
requested review from
nikku,
crobbins215,
abdul99ahad and
lmbateman
philippfromme
changed the title
| padding: 0 !important; | ||
| } | ||
|
|
||
| th, |
There was a problem hiding this comment.
This is probably dangerous (due to missing namespacing).
I'll look into prefixing it.
There was a problem hiding this comment.
Yes, indeed. Sorry, I marked it as ready to review without reassessing the CSS so it was still very much in a work-in-progress state. 😅
| padding: 0 !important; | ||
| } | ||
|
|
||
| th, |
There was a problem hiding this comment.
| th, | |
| .bio-vo-variable-table th, |
There was a problem hiding this comment.
I realized we already apply the whole fixes locally to the variables panel .bio-vo-tab-content, so no additional fixes should be needed.
|
Assessment: It fits much better into the existing UX. I was not able to fix the popup issue (#4496) but I'll continue to investigate as a follow-up. Let's merge it for now (as a quick fix), and investigate further improvements in the future. |
Proposed Changes
Adjusts the IBM Carbon styles of the variable outline tab so that it looks more like it's part of the modeler. This is a proposal that needs discussion in terms of how and where to actually fix the IBM Carbon styles and whether the fixes should also work for the next IBM Carbon component we introduce.
Before
After
Related to #4267