-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add explicit styles for welcome tab #4599
Conversation
7cebf86
to
f959c24
Compare
The root cause of this issue are carbon styles user in variable outline. There is no simple way to scope them without some hacking (thanks @marstamm), so I'll stick with explicit styles on the side of welcome page. I realized there is no need to introduce new class as I can just reuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great root causing on this issue! What we can see is that the carbon normalization (that is lazy loaded!) has many effects, and will always override whatever we normalize in the modeler.
What I propose is that we tackle this in an orderly manner as part of #4511, which I've moved to ready
.
Before
After
Root cause
(Again, Carbon "normalization"):
7d16afb
to
af6af15
Compare
Overlays and modals now work with a reasonable line-height again. Related to #4555
af6af15
to
754b0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged from my end (#4599 (comment)).
@lmbateman Let's verify on tomorrows nightly if they look odd still. Should be fixed with this PR. |
Closes #4555
Proposed Changes
Welcome tab now always looks the same, even if you open and close some diagrams.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}