Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rosa submariner #54

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat: rosa submariner #54

wants to merge 24 commits into from

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Aug 29, 2024

tests related to the integration of submariner in a multicluster deployement (https://github.com/camunda/team-infrastructure-experience/issues/253)

@leiicamundi leiicamundi self-assigned this Aug 29, 2024
@leiicamundi leiicamundi changed the title feat: rosa submariner [DON'T MERGE] [DON'T MERGE] feat: rosa submariner Aug 29, 2024
@Langleu
Copy link
Member

Langleu commented Aug 30, 2024

Readme looks good 👍.
I didn't test it out but the steps make sense and everything is detailed.
Agree, would probably not merge it for the time being but on a branch is good to potentially in the future turn this into a fully supported approach + potential alignment with submariner for other providers.

@maxdanilov
Copy link
Member

Looks good to me as well! Thanks for creating a detailed readme for how to recreate the setup, really well done 🙇 Let's also convert this to draft so it's not merged by chance.

@maxdanilov maxdanilov marked this pull request as draft August 30, 2024 21:15
@leiicamundi
Copy link
Contributor Author

Thanks, @maxdanilov and @Langleu, for the feedback.

I’ve moved the example to an examples folder and added a note indicating that it’s intended as a proof of concept (PoC).

I’m okay with keeping it on a dedicated branch, but it might need to be synchronized with the main branch over time. What are your thoughts on keeping the examples folder on the same branch?

@maxdanilov
Copy link
Member

maxdanilov commented Sep 3, 2024

I think unless we're ready to commit to these examples as to something we vouch to maintaining and ensuring they're always functioning (and customers picking these up), we should keep in on the branch. I'd say let's keep it as is on the branch/draft PR and productise as a part of the OpenShift dual-region epic.

@leiicamundi leiicamundi changed the title [DON'T MERGE] feat: rosa submariner feat: rosa submariner Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants