Kafka connector loop retry #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
reviewed
Jun 26, 2024
connectors/kafka/src/main/java/io/camunda/connector/kafka/inbound/KafkaExecutable.java
Outdated
Show resolved
Hide resolved
johnBgood
previously approved these changes
Jun 26, 2024
sbuettner
previously approved these changes
Jun 27, 2024
sbuettner
force-pushed
the
kafka-connector-loop-retry
branch
from
c813afa to
9e0022e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sbuettner
force-pushed
the
kafka-connector-loop-retry
branch
from
9e0022e to
d1718a6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@chillleader This one might require e2e test fixes. |
chillleader
force-pushed
the
kafka-connector-loop-retry
branch
from
8a68f69 to
1d7acfe
Compare
|
@sbuettner this should have fixed the test |
johnBgood
approved these changes
Jul 15, 2024
sbuettner
approved these changes
Jul 16, 2024
sbuettner
force-pushed
the
kafka-connector-loop-retry
branch
from
47ce498 to
9575a75
Compare
This was referenced Jul 22, 2024
|
/backport |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.3
git worktree add -d .worktree/backport-2792-to-release/8.3 origin/release/8.3
cd .worktree/backport-2792-to-release/8.3
git switch --create backport-2792-to-release/8.3
git cherry-pick -x 807071e2ae74a81e73d2689505a131e1cdd8bb7e |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.4
git worktree add -d .worktree/backport-2792-to-release/8.4 origin/release/8.4
cd .worktree/backport-2792-to-release/8.4
git switch --create backport-2792-to-release/8.4
git cherry-pick -x 807071e2ae74a81e73d2689505a131e1cdd8bb7e |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.5
git worktree add -d .worktree/backport-2792-to-release/8.5 origin/release/8.5
cd .worktree/backport-2792-to-release/8.5
git switch --create backport-2792-to-release/8.5
git cherry-pick -x 807071e2ae74a81e73d2689505a131e1cdd8bb7e |
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Jul 25, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting (cherry picked from commit 807071e)
chillleader
added a commit
that referenced
this pull request
Aug 7, 2024
* fix(kafka): retry the main consumer loop with 30 seconds backoff * reduce test wait duration * lint * switch to failsafe * set number of retries to -1 (unlimited) * use constant for retry number * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * try fixing the integration test * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds retries to the Kafka connector consumer loop.
Previously, when the consumer threw an exception, it just stopped processing until the process is redeployed. The new default is to retry this as long as the connector is active, with a backoff of 30 seconds.
Related issues
closes #2750