842 aws bedrock connector #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathias-vandaele
changed the title
sbuettner
reviewed
Jul 11, 2024
connectors/aws/aws-bedrock/pom.xml
Outdated
Comment on lines
18
to
22
| <properties> | ||
| <maven.compiler.source>21</maven.compiler.source> | ||
| <maven.compiler.target>21</maven.compiler.target> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> |
There was a problem hiding this comment.
Dont we inherit it from the parent?
sbuettner
reviewed
Jul 11, 2024
| inputVariables = {"authentication", "configuration", "action", "data"}, | ||
| type = "io.camunda:aws-bedrock:1") | ||
| @ElementTemplate( | ||
| id = "io.camunda.connectors.AWSBEDROCK.v1", |
There was a problem hiding this comment.
Suggested change
| id = "io.camunda.connectors.AWSBEDROCK.v1", | |
| id = "io.camunda.connectors.aws.bedrock.v1", |
johnBgood
reviewed
Jul 11, 2024
bundle/default-bundle/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
johnBgood
reviewed
Jul 11, 2024
...ors/aws/aws-bedrock/src/main/java/io/camunda/connector/aws/bedrock/core/BedrockExecutor.java
Outdated
Show resolved
Hide resolved
johnBgood
reviewed
Jul 11, 2024
sbuettner
reviewed
Jul 11, 2024
Comment on lines
11
to
36
| public class PreviousMessage { | ||
| private String message; | ||
| private ConversationRole role; | ||
|
|
||
| public PreviousMessage(String message, ConversationRole role) { | ||
| this.message = message; | ||
| this.role = role; | ||
| } | ||
|
|
||
| public PreviousMessage() {} | ||
|
|
||
| public String getMessage() { | ||
| return message; | ||
| } | ||
|
|
||
| public void setMessage(String message) { | ||
| this.message = message; | ||
| } | ||
|
|
||
| public ConversationRole getRole() { | ||
| return role; | ||
| } | ||
|
|
||
| public void setRole(ConversationRole role) { | ||
| this.role = role; | ||
| } |
There was a problem hiding this comment.
Can we create a simple data record like this:
public record Message(String text, String role) {}
We should try to avoid serializing external data models like in this case ConversationRole.
johnBgood
reviewed
Jul 11, 2024
|
|
||
| import software.amazon.awssdk.services.bedrockruntime.model.ConversationRole; | ||
|
|
||
| public class PreviousMessage { |
There was a problem hiding this comment.
can be converted to a record ?
sbuettner
reviewed
Jul 11, 2024
| binding = @TemplateProperty.PropertyBinding(name = "data.messagesHistory")) | ||
| @Valid | ||
| @JsonSetter(nulls = Nulls.SKIP) | ||
| private List<PreviousMessage> messagesHistory = new ArrayList<>(); |
sbuettner
reviewed
Jul 11, 2024
| binding = @TemplateProperty.PropertyBinding(name = "data.newMessage")) | ||
| @Valid | ||
| @NotBlank | ||
| private String newMessage; |
sbuettner
reviewed
Jul 11, 2024
…ock (checkpoint 2)
…ock (checkpoint 3)
mathias-vandaele
force-pushed
the
842-aws-bedrock-connector
branch
from
a2cf9b6 to
4273b14
Compare
johnBgood
reviewed
Jul 12, 2024
...aws/aws-bedrock/src/main/java/io/camunda/connector/aws/bedrock/BedrockConnectorFunction.java
Show resolved
Hide resolved
johnBgood
reviewed
Jul 12, 2024
| @ElementTemplate.PropertyGroup(id = "invokeModel", label = "Invoke Model"), | ||
| @ElementTemplate.PropertyGroup(id = "converse", label = "Converse"), | ||
| }, | ||
| documentationRef = "https://docs.camunda.io/docs/", |
There was a problem hiding this comment.
this needs to be update with the future doc link
johnBgood
previously approved these changes
Jul 12, 2024
...ctors/aws/aws-bedrock/src/main/java/io/camunda/connector/aws/bedrock/model/ConverseData.java
Outdated
Show resolved
Hide resolved
| import software.amazon.awssdk.services.bedrockruntime.model.Message; | ||
|
|
||
| @TemplateSubType(id = "converse", label = "Converse") | ||
| public final class ConverseData implements RequestData { |
There was a problem hiding this comment.
let's keep in my that if we don't override toString we might leak information from nextMessage or the previous messages.
Not sure it's an issue for this connector, it's more a FYI :) We usually do that for credentials etc
johnBgood
approved these changes
Jul 15, 2024
sbuettner
approved these changes
Jul 17, 2024
chillleader
pushed a commit
that referenced
this pull request
Aug 7, 2024
* feat(aws-bedrock): new outbound connector implementation for aws bedrock * feat(aws-bedrock): new outbound connector implementation for aws bedrock (checkpoint 2) * feat(aws-bedrock): new outbound connector implementation for aws bedrock (checkpoint 3) * feat(aws-bedrock): setting application.properties as it was before (checkpoint 4) * feat(aws-bedrock): fix comments from PR (checkpoint 5) * feat(aws-bedrock): fix indent (checkpoint 6) * feat(aws-bedrock): fix last minor comment (checkpoint 7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes https://github.com/camunda/team-connectors/issues/842