Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document): enable Camunda document store #3762

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented Dec 6, 2024

Description

Enable the Camunda document store by default

Related issues

closes #

Checklist

  • PR has a milestone or the no milestone label.

@chillleader chillleader requested a review from a team as a code owner December 6, 2024 13:23
@chillleader chillleader self-assigned this Dec 6, 2024
johnBgood
johnBgood previously approved these changes Dec 9, 2024
@chillleader chillleader changed the title fix(document): update document type property name fix(document): enable Camunda document store Dec 9, 2024
johnBgood
johnBgood previously approved these changes Dec 9, 2024
sbuettner
sbuettner previously approved these changes Dec 9, 2024
@chillleader chillleader force-pushed the fix-document-type-property-name branch from 2924fc8 to 80b2bcf Compare December 9, 2024 19:53
Comment on lines +50 to +53
public static void registerDocumentModule(
DocumentFactory factory, DocumentModuleSettings settings) {
DEFAULT_MAPPER.registerModule(new JacksonModuleDocument(factory, null, settings));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now but we should avoid static initialization.

@chillleader chillleader added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 3f44182 Dec 10, 2024
11 checks passed
@chillleader chillleader deleted the fix-document-type-property-name branch December 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants