Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix infinite loop in actionlint #311

Merged
merged 1 commit into from
Dec 11, 2024
Merged

ci: fix infinite loop in actionlint #311

merged 1 commit into from
Dec 11, 2024

Conversation

Kerruba
Copy link
Contributor

@Kerruba Kerruba commented Dec 11, 2024

Related to: camunda/team-infrastructure#620

@Kerruba Kerruba requested review from kellervater and cmur2 December 11, 2024 15:25
kellervater
kellervater reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this somewhere?
Just want to avoid that we need to reiterate again.

kellervater
kellervater approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed with the author: tested locally on dev workstation.

@Kerruba
Copy link
Contributor Author

Kerruba commented Dec 11, 2024

Here a test on a real case scenario: https://github.com/camunda/camunda/actions/runs/12279941772/job/34265221798
Previously this wasn't working due to the infinite loop, with this change the infinite loop is gone

@Kerruba Kerruba merged commit f9362c3 into main Dec 11, 2024
3 checks passed
@Kerruba Kerruba deleted the gh-620-fix-infinite-loop branch December 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellervater kellervater kellervater approved these changes

@cmur2 cmur2 Awaiting requested review from cmur2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerruba @kellervater