Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowedIn is missing for taskHeaders/headers #7

Closed
barmac opened this issue Feb 24, 2021 · 0 comments · Fixed by #8
Closed

allowedIn is missing for taskHeaders/headers #7

barmac opened this issue Feb 24, 2021 · 0 comments · Fixed by #8
Assignees
@barmac
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 24, 2021 •
edited by pinussilvestrus
Loading

Describe the Bug

As in the title. For now, you can morph a Service Task to a Receive Task and the headers stay in the extension elements.

Steps to Reproduce

  1. create a Service Task
  2. add some headers
  3. replace with a Receive Task
  4. see the task headers stay

Expected Behavior

The headers got removed.

Hint: We need some metadata.allowedIn for the task headers (for service and user tasks, currently).
@barmac barmac added the bug Something isn't working label Feb 24, 2021
@barmac barmac mentioned this issue Feb 24, 2021
Merged
@MaxTru MaxTru added the ready Ready to be worked on label Feb 24, 2021 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added the good first issue Good for newcomers label Mar 9, 2021
@pinussilvestrus pinussilvestrus added backlog Queued in backlog and removed ready Ready to be worked on labels Mar 19, 2021 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Apr 6, 2021
@barmac barmac self-assigned this Apr 14, 2021
barmac added a commit that referenced this issue Apr 14, 2021
@barmac
feat: allow zeebe:TaskHeaders only in bpmn:ServiceTask
841f92f 
Closes #7
@barmac barmac mentioned this issue Apr 14, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed backlog Queued in backlog in progress Currently worked on labels Apr 14, 2021
@nikku nikku closed this as completed in #8 Apr 14, 2021
nikku pushed a commit that referenced this issue Apr 14, 2021
@barmac
feat: allow zeebe:TaskHeaders only in bpmn:ServiceTask
ab86b6b 
Closes #7
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow zeebe:TaskHeaders only in bpmn:ServiceTask camunda/zeebe-bpmn-moddle
3 participants
@pinussilvestrus @barmac @MaxTru