Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict taskDefinition for zeebeServiceTasks only #14

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Sep 20, 2021

Current Situation

  • TaskDefinition property doesn't have the meta.allowedIn field in the zeebe.json

Problem

  • For properties without the meta.allowedIn field, it is assumed to be allowed for all elements
  • Doesn't make sense since it's only present for zeebe Service Tasks

Solution

  • Add zeebeServiceTasks in the meta.allowedIn field for the taskDefinition property in the zeebe.json

- Only allow `zeebeServiceTasks` to have `taskDefinition` elements , instead of allowing it to all elements
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 20, 2021
@smbea smbea requested a review from barmac September 20, 2021 15:15
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@smbea smbea merged commit 0d1a410 into master Sep 20, 2021
@smbea smbea deleted the allow-only-zeebeservicetasks-in-taskdefinition branch September 20, 2021 15:52
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants