Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zeebe:bindingType for zeebe:CalledDecision, zeebe:CalledElement and zeebe:FormDefinition #61

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

philippfromme
Copy link
Contributor

Adds support zeebe:bindingType to zeebe:CalledDecision, zeebe:CalledElement and zeebe:FormDefinition.

Examples

<bpmn:businessRuleTask id="BusinessRuleTask_1">
  <bpmn:extensionElements>
    <zeebe:calledDecision bindingType="deployment" decisionId="foo" resultVariable="bar" />
  </bpmn:extensionElements>
</bpmn:businessRuleTask>
<bpmn:callActivity id="CallActivity_1">
  <bpmn:extensionElements>
    <zeebe:calledElement bindingType="deployment" processId="foo" propagateAllChildVariables="false" />
  </bpmn:extensionElements>
</bpmn:callActivity>
<bpmn:userTask id="UserTask_1">
  <bpmn:extensionElements>
    <zeebe:formDefinition bindingType="deployment" formId="foo" />
  </bpmn:extensionElements>
</bpmn:userTask>

Related to camunda/camunda-modeler#4385

@@ -315,7 +315,7 @@
{
"name": "CalledDecision",
"superClass": [
"Element"
"BindingTypeSupported"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[not blocking] Are we going to use the parent type information anywhere? If not, I'd rather expect to use extends property on the type defining the bindingType.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean "extends": [ "zeebe:CalledDecision", "zeebe:CalledElement", "zeebe:FormDefinition" ]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barmac I made the change you suggested. Makes much more sense. Good catch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@barmac
Copy link
Collaborator

barmac commented Jul 19, 2024

I left one optional comment but it looks ready to merge.

@philippfromme philippfromme merged commit ef2ad62 into main Jul 22, 2024
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 22, 2024
@philippfromme philippfromme deleted the binding-type branch July 22, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants