Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.3] Timer events fail with specific values #1071

Merged
6 commits merged into from
Feb 6, 2024
Merged

[Backport stable/8.3] Timer events fail with specific values #1071

6 commits merged into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. fix(engine): fixing how we compare byte arrays 

    Using Guava UnsignedBytes.compare instead of comparing signed bytes

(cherry picked from commit e82cc5c)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    aa40713 View commit details
    Browse the repository at this point in the history

  2. test(engine): fixing how we compare byte arrays 

    Adding tests for Bytes class

(cherry picked from commit 563b095)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    31a04c3 View commit details
    Browse the repository at this point in the history

  3. test(qa): adding tests to verify different dates 

    Adding tests to verify timers work correctly for different dates

(cherry picked from commit d9b3b5e)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9f5deaf View commit details
    Browse the repository at this point in the history

  4. fix(engine): use Arrays.compareUnsigned 

    Using Arrays.compareUnsigned instead of a custom compareTo implementation
Added two additional uint tests

(cherry picked from commit 320bcab)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5806a9b View commit details
    Browse the repository at this point in the history

  5. refactor(engine): renamed test methods 

    (cherry picked from commit 9dca20b)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    45e5980 View commit details
    Browse the repository at this point in the history

  6. refactor(engine): introducing parametrized test 

    (cherry picked from commit 5abd87e)
    @ana-vinogradova-camunda @github-actions
    ana-vinogradova-camunda authored and github-actions[bot] committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f14e0a8 View commit details
    Browse the repository at this point in the history