Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update grpc version to 1.68.0 to fix incompatiblity #1258

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Nov 4, 2024

Description

The io.camunda:zeebe-client-java was already using 1.68.0 while ZPT used 1.65.1 which caused the client to fail. As ZPT itself depends on GRPC we need to keep both versions generally in sync.

Kudos to @saig0 for root-causing this!

Related issues

closes #1257

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

The io.camunda:zeebe-client-java was already using 1.68.0 while
ZPT used 1.65.1 which caused the client to fail. As ZPT itself depends on GRPC we need to keep both versions generally in sync.

Kudos to @saig0 for root-causing this!
Copy link

github-actions bot commented Nov 4, 2024

Test Results

 49 files   - 1   49 suites   - 1   1m 24s ⏱️ -14s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
435 runs   - 3  435 ✅  - 3  0 💤 ±0  0 ❌ ±0 

Results for commit 44c8d3f. ± Comparison against base commit 2a99de0.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saig0 saig0 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 8048733 Nov 4, 2024
10 checks passed
@saig0 saig0 deleted the meg-1257-update-grpc branch November 4, 2024 12:14
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8.6.4] The Zeebe client reports the error: Panic! This is a bug!
3 participants