Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add event type for process instance record #597

Merged
1 commit merged into from
Dec 13, 2022

Conversation

skayliu
Copy link
Contributor

@skayliu skayliu commented Dec 10, 2022

Description

Like BpmnElementType, BpmnEventType has been introduced to Zeebe SNAPSHOT for process instance record. so that as a consumer of the record stream, you can distinguish the type of event that is processed.

Related issues

closes #596

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@skayliu
Copy link
Contributor Author

skayliu commented Dec 10, 2022

Hi, @korthout @remcowesterhoud, Please check this out. Thank you.

@remcowesterhoud remcowesterhoud self-requested a review December 13, 2022 10:35
@github-actions
Copy link

github-actions bot commented Dec 13, 2022

Test Results

  47 files  ±0    47 suites  ±0   1m 47s ⏱️ -35s
113 tests ±0  113 ✔️ ±0  0 💤 ±0  0 ±0 
362 runs  ±0  362 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit bb32c41. ± Comparison against base commit 9b2396c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

bors merge

ghost pushed a commit that referenced this pull request Dec 13, 2022
597: feat(filters): add event type for process instance record r=remcowesterhoud a=skayliu

## Description

Like `BpmnElementType`, `BpmnEventType` has been introduced to Zeebe SNAPSHOT for process instance record. so that as a consumer of the record stream, you can distinguish the type of event that is processed.


## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #596 

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible) before requesting a review. -->

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to backport the fix

Testing:
* [x] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [x] The behavior is tested manually

Documentation:
* [ ] Javadoc has been written
* [ ] The documentation is updated


Co-authored-by: skayliu <skay463@163.com>
@remcowesterhoud
Copy link
Contributor

bors cancel

I'll have to review and merge #601 first

@ghost
Copy link

ghost commented Dec 13, 2022

Canceled.

@remcowesterhoud
Copy link
Contributor

@skayliu please rebase this on main 🙂

Like BpmnElementType, BpmnEventType has been introduced to Zeebe SNAPSHOT for process instance record. so that as a consumer of the record stream, you can distinguish the type of event that is processed.
@lzgabel
Copy link

lzgabel commented Dec 13, 2022

Done.

@remcowesterhoud. Please check this out. ❤️

@remcowesterhoud
Copy link
Contributor

Thank you!

bors merge

@ghost
Copy link

ghost commented Dec 13, 2022

Build succeeded:

@ghost ghost merged commit 9badb55 into camunda:main Dec 13, 2022
@skayliu skayliu deleted the 596-add-event-type branch December 13, 2022 14:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event type for process instance record
3 participants