Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.1] Inject ZPT related fields into superclasses #609

Merged
2 commits merged into from
Dec 15, 2022

Conversation

github-actions[bot]
Copy link

Description

Backport of #605 to stable/8.1.

relates to #604

The extensions should inject the ZeebeClient and the ZeebeTestEngine into the fields available with this type. This test will verify that this happens for both the embedded engine and the testcontainers engine.

(cherry picked from commit db97f19)
The extensions should inject the engine, client and recordstream into the fields that are available. Before this only tried to inject them into the annotated class. This does not work when inheritance is used and the fields are defined on the superclass of the annotated class.

This commit changes the extension so that it will first look on the annotated class. If it cannot find any of the annotations here, it will work it's way up to the superclass and so on until it either found a field it is able to inject, or no fields at all.

(cherry picked from commit b912ba9)
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ghost
Copy link

ghost commented Dec 15, 2022

Build succeeded:

@ghost ghost merged commit b4511a1 into stable/8.1 Dec 15, 2022
@ghost ghost deleted the backport-605-to-stable/8.1 branch December 15, 2022 11:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant