Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): support standalone decision evaluation #621

Merged
2 commits merged into from
Jan 19, 2023

Conversation

koevskinikola
Copy link
Member

@koevskinikola koevskinikola commented Dec 28, 2022

Description

Add support for standalone decision evaluation in the Zeebe process test library.

Related issues

closes #573

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@koevskinikola koevskinikola self-assigned this Dec 28, 2022
@github-actions
Copy link

github-actions bot commented Dec 28, 2022

Test Results

  47 files  +  9    47 suites  +9   1m 57s ⏱️ +59s
116 tests +  6  116 ✔️ +  9  0 💤 ±0  0  - 3 
371 runs  +66  371 ✔️ +69  0 💤 ±0  0  - 3 

Results for commit 9b5301a. ± Comparison against base commit f01b7b6.

♻️ This comment has been updated with latest results.

@koevskinikola
Copy link
Member Author

@Zelldon, I've created this PR in case you want to make progress more quickly on #620. The code will remove the error thrown by the missing evaluateDecision method.

So, if you would like to get unblocked, you can cherry-pick 43f8056.

Unfortunately, the PR is incomplete, as I can't add test coverage since the corresponding Java client PR is still in review (camunda/camunda#11048). And I would prefer if someone from the ZPA team reviews that PR.

Add support for standalone decision evaluation in the Zeebe process test library.
@koevskinikola koevskinikola marked this pull request as ready for review January 19, 2023 11:25
@koevskinikola koevskinikola force-pushed the 573-evaluate-decisions branch from f0652f5 to 9b5301a Compare January 19, 2023 11:26
@koevskinikola
Copy link
Member Author

@remcowesterhoud, as the PR doesn't add any new assertions, I didn't make any changes to the documentation. Let me know if you think that the documentation should be updated in some way.

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bors merge

@ghost
Copy link

ghost commented Jan 19, 2023

Build succeeded:

@ghost ghost merged commit cff51c2 into zell-signal-log Jan 19, 2023
@ghost ghost deleted the 573-evaluate-decisions branch January 19, 2023 12:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants