Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): ensure factory fails for snapshot only DB #867

Merged
1 commit merged into from
Aug 22, 2023

Conversation

npepinpe
Copy link
Member

Description

This PR fixes a compilation issue, and disables opening so-called "snapshot-only" databases, since snapshots are not supported by in-memory DBs.

Related issues

closes #866

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud
Copy link
Contributor

LGTM! Thanks 🙏

bors merge

@ghost
Copy link

ghost commented Aug 22, 2023

👎 Rejected by too few approved reviews

@npepinpe
Copy link
Member Author

:|

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Bors merge

@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   2m 1s ⏱️ -6s
100 tests ±0  100 ✔️ ±0  0 💤 ±0  0 ±0 
323 runs  ±0  323 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 426e366. ± Comparison against base commit 661de72.

@ghost
Copy link

ghost commented Aug 22, 2023

Build succeeded:

@ghost ghost merged commit 40d0675 into main Aug 22, 2023
@ghost ghost deleted the np-866-no-snapshot-db branch August 22, 2023 16:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error on building zeebe-process-test against Zeebe SNAPSHOT
2 participants