Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 876 stable/8.3 #932

Merged
2 commits merged into from
Oct 11, 2023
Merged

Backport 876 stable/8.3 #932

2 commits merged into from
Oct 11, 2023

Conversation

remcowesterhoud
Copy link
Contributor

When iterating in an open transaction, we would create an iterator containing all entries in the database as well as the entries in the transaction cache. This ensures any keys added in the same transaction are also encountered during iterating.

We do not do anything with the keys that are deleted within the transaction. As a result, when iterating we will go over keys that are already deleted. This is wrong. The keys are deleted, so we should not encounter them anymore during iterating.

(cherry picked from commit cc45114)
When iterating in an open transaction, we would create an iterator containing all entries in the database as well as the entries in the transaction cache. This ensures any keys added in the same transaction are also encountered during iterating.

We do not do anything with the keys that are deleted within the transaction. As a result, when iterating we will go over keys that are already deleted. This is wrong. The keys are deleted, so we should not encounter them anymore during iterating.

(cherry picked from commit 84be02b)
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

@github-actions
Copy link

Test Results

  47 files    47 suites   1m 53s ⏱️
102 tests 102 ✔️ 0 💤 0
329 runs  329 ✔️ 0 💤 0

Results for commit 5dc9f5f.

@ghost
Copy link

ghost commented Oct 11, 2023

Build succeeded:

@ghost ghost merged commit bde06f3 into stable/8.3 Oct 11, 2023
9 checks passed
@ghost ghost deleted the backport-876-stable/8.3 branch October 11, 2023 08:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants