Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 876 to stable/8.1 #934

Merged
2 commits merged into from
Oct 11, 2023
Merged

Backport 876 to stable/8.1 #934

2 commits merged into from
Oct 11, 2023

Conversation

remcowesterhoud
Copy link
Contributor

When iterating in an open transaction, we would create an iterator containing all entries in the database as well as the entries in the transaction cache. This ensures any keys added in the same transaction are also encountered during iterating.

We do not do anything with the keys that are deleted within the transaction. As a result, when iterating we will go over keys that are already deleted. This is wrong. The keys are deleted, so we should not encounter them anymore during iterating.

(cherry picked from commit cc45114)
When iterating in an open transaction, we would create an iterator containing all entries in the database as well as the entries in the transaction cache. This ensures any keys added in the same transaction are also encountered during iterating.

We do not do anything with the keys that are deleted within the transaction. As a result, when iterating we will go over keys that are already deleted. This is wrong. The keys are deleted, so we should not encounter them anymore during iterating.

(cherry picked from commit 84be02b)
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   2m 10s ⏱️ +7s
114 tests +1  114 ✔️ +1  0 💤 ±0  0 ±0 
365 runs  +3  365 ✔️ +3  0 💤 ±0  0 ±0 

Results for commit 439fd11. ± Comparison against base commit c4bf701.

@ghost
Copy link

ghost commented Oct 11, 2023

Build succeeded:

  • Test summary

@ghost ghost merged commit 084bdff into stable/8.1 Oct 11, 2023
9 checks passed
@ghost ghost deleted the backport-876-to-stable/8.1 branch October 11, 2023 07:58
github-merge-queue bot referenced this pull request in camunda/camunda Aug 6, 2024
….18 (stable/8.2) (#20811)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.camunda:zeebe-process-test-filters](https://github.com/camunda-community-hub/zeebe-process-test-root/zeebe-process-test-filters/)
([source](https://github.com/camunda/zeebe-process-test)) | `8.1.9` ->
`8.1.18` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.camunda:zeebe-process-test-filters/8.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.camunda:zeebe-process-test-filters/8.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.camunda:zeebe-process-test-filters/8.1.9/8.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.camunda:zeebe-process-test-filters/8.1.9/8.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>camunda/zeebe-process-test
(io.camunda:zeebe-process-test-filters)</summary>

###
[`v8.1.18`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.18)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.17...8.1.18)

#### What's Changed

- Release 8.1.17 by [@&#8203;camundait](https://github.com/camundait)
in
[https://github.com/camunda/zeebe-process-test/pull/922](https://github.com/camunda/zeebe-process-test/pull/922)
- Backport 876 to stable/8.1 by
[@&#8203;remcowesterhoud](https://github.com/remcowesterhoud) in
[https://github.com/camunda/zeebe-process-test/pull/934](https://github.com/camunda/zeebe-process-test/pull/934)

**Full Changelog**:
camunda/zeebe-process-test@8.1.17...8.1.18

###
[`v8.1.17`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.17)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.16...8.1.17)

#### What's Changed

- Release 8.1.16 by [@&#8203;camundait](https://github.com/camundait)
in
[https://github.com/camunda/zeebe-process-test/pull/881](https://github.com/camunda/zeebe-process-test/pull/881)
- \[Backport stable/8.1] fix (test-engine): Apply retryBackOff of
failJob command by
[@&#8203;github-actions](https://github.com/github-actions) in
[https://github.com/camunda/zeebe-process-test/pull/899](https://github.com/camunda/zeebe-process-test/pull/899)

**Full Changelog**:
camunda/zeebe-process-test@8.1.16...8.1.17

###
[`v8.1.16`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.16)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.15...8.1.16)

**Full Changelog**:
camunda/zeebe-process-test@8.1.15...8.1.16

###
[`v8.1.15`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.15)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.14...8.1.15)

#### What's Changed

- Release 8.1.14 by [@&#8203;camundait](https://github.com/camundait)
in
[https://github.com/camunda/zeebe-process-test/pull/820](https://github.com/camunda/zeebe-process-test/pull/820)
- \[Backport stable/8.1] automerge camundait and backport PRs by
[@&#8203;remcowesterhoud](https://github.com/remcowesterhoud) in
[https://github.com/camunda/zeebe-process-test/pull/844](https://github.com/camunda/zeebe-process-test/pull/844)

**Full Changelog**:
camunda/zeebe-process-test@8.1.14...8.1.15

###
[`v8.1.14`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.14)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.13...8.1.14)

#### What's Changed

- \[Backport stable/8.1] Verify processId when extracting called process
by [@&#8203;remcowesterhoud](https://github.com/remcowesterhoud) in
[https://github.com/camunda/zeebe-process-test/pull/804](https://github.com/camunda/zeebe-process-test/pull/804)
- Release 8.1.13 by [@&#8203;camundait](https://github.com/camundait)
in
[https://github.com/camunda/zeebe-process-test/pull/791](https://github.com/camunda/zeebe-process-test/pull/791)

**Full Changelog**:
camunda/zeebe-process-test@8.1.13...8.1.14

###
[`v8.1.13`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.13)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.12...8.1.13)

**Full Changelog**:
camunda/zeebe-process-test@8.1.12...8.1.13

###
[`v8.1.12`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.12)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.11...8.1.12)

#### What's Changed

- Release 8.1.12 by
[@&#8203;remcowesterhoud](https://github.com/remcowesterhoud) in
[https://github.com/camunda/zeebe-process-test/pull/750](https://github.com/camunda/zeebe-process-test/pull/750)
- \[Backport stable/8.1] Support ProcessInstanceBatch records by
[@&#8203;remcowesterhoud](https://github.com/remcowesterhoud) in
[https://github.com/camunda/zeebe-process-test/pull/748](https://github.com/camunda/zeebe-process-test/pull/748)

**Full Changelog**:
camunda/zeebe-process-test@8.1.11...8.1.12

###
[`v8.1.11`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.11)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.10...8.1.11)

#### What's Changed

- deps: upgrade zeebe to 8.1.11 by
[@&#8203;oleschoenburg](https://github.com/oleschoenburg) in
[https://github.com/camunda/zeebe-process-test/pull/739](https://github.com/camunda/zeebe-process-test/pull/739)

**Full Changelog**:
camunda/zeebe-process-test@8.1.10...8.1.11

###
[`v8.1.10`](https://github.com/camunda/zeebe-process-test/releases/tag/8.1.10)

[Compare
Source](https://github.com/camunda/zeebe-process-test/compare/8.1.9...8.1.10)

#### What's Changed

- deps: bump zeebe to 8.1.10 by
[@&#8203;npepinpe](https://github.com/npepinpe) in
[https://github.com/camunda/zeebe-process-test/pull/722](https://github.com/camunda/zeebe-process-test/pull/722)

**Full Changelog**:
camunda/zeebe-process-test@8.1.9...8.1.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/camunda/camunda).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoic3RhYmxlLzguMiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants