Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab-bag PR: HTTP QoL, timeout config, SQL transactions #311

Merged
merged 8 commits into from
Jun 16, 2023
Merged

Conversation

jsoverson
Copy link
Contributor

This PR is the result of fixes and changes made during production deployments.

It:

  • removes global timeouts in favor of per-operation timeouts
  • changes 501 errors on missing router to 404s
  • changes Internal Server Errors to be more descriptive in logs and less descriptive in the response.
  • adds quoted field syntax to access deeply nested fields that have spaces and symbols.
  • adds on_error handling to (ms sql server only for now) SQL components with Rollback/Commit/Ignore values.
  • adds more differentiation among reported HTTP errors.
  • misc other ms sql and http fixes.

@jsoverson
Copy link
Contributor Author

Pushed a commit that sync's the vscode rust-analyzer settings with the command used in CI to mitigate PR failures for code that looked OK locally.

@jsoverson jsoverson merged commit f5c8df4 into main Jun 16, 2023
@jsoverson jsoverson deleted the http-qol branch June 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants