Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved port inference (+ added flow sequences) #380

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

jsoverson
Copy link
Contributor

This PR improves wick's ability to infer port names so they can be omitted more frequently. Because unary components are trivial to infer, the PR also adds the ability to chain flow expressions and omit IDs more frequently, i.e. <> -> comp::op -> comp2::op2 -> <>

While adding this, I added the wick config subcommand and two sub-subcommands:
-wick config dot to generate dot syntax flow graph for a composite component.
-wick config expand to validate and output the expanded configuration that wick runs with.

This PR:

  • Adds a "slow transaction" warning with active operations for transactions that last longer than 15 seconds without progressing.
  • Starts operations on first packet vs starting them all at tx start. This means that downstream components no longer need to adopt the timeouts of their upstreams.
  • Made wick's internal representation of configuration serializable (but not deserializable, it should always come from a v# config first).

@jsoverson jsoverson merged commit 978690e into main Jul 20, 2023
5 checks passed
@jsoverson jsoverson deleted the port-inference-2 branch July 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants