Reorganized tracing span hierarchy #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoverson
force-pushed
the
tracing-redux
branch
from
073f6dc
to
8af480a
Compare
fawadasaurus
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the tracing spans were loosely organized with
Span::follows_fromvs. a parent/child relationship, making browsing telemetry without pre-processing it impractical.Now the spans are organized with a hierarchy that starts at a root invocation or a practical stand-in, like an HTTP request. Pre-invocation initiators can also pre-generate a transaction ID so their child spans stay better grouped. That means things like HTTP requests can report a transaction ID that can be used to query and filter all child invocations.